fix: use separate resolvers for each file in join (#1291)

.changeset/dull-ducks-beam.md

@@ -0,0 +1,6 @@
+---
+'@redocly/openapi-core': patch
+'@redocly/cli': patch
+---
+
+Fixed an issue with nested refs in the `join` command.

__tests__/commands.test.ts

@@ -162,6 +162,7 @@ describe('E2E', () => {
         'multiple-tags-in-same-files',
         'references-in-parameters',
         'ignore-decorators',
+        'multi-references-to-one-file',
       ];
 
       test.each(testDirNames)('test: %s', (dir) => {

__tests__/join/multi-references-to-one-file/bar.yaml

@@ -0,0 +1,16 @@
+openapi: 3.0.3
+tags:
+  - name: CreateBar
+    description: Create a new Bar
+paths:
+  /bar/:
+    post:
+      summary: Create a single bar
+      operationId: createBar
+      responses:
+        '200':
+          description: One single bar
+          content:
+            application/json:
+              schema:
+                $ref: './nested/Response.yaml'

__tests__/join/multi-references-to-one-file/foo.yaml

@@ -0,0 +1,25 @@
+openapi: 3.0.3
+info:
+  title: Sample API
+  description: My sample api
+  version: 0.0.1
+  license:
+    name: 'Internal'
+    url: 'https://mycompany.com/license'
+tags:
+  - name: GetSingleFoo
+    description: Get a single foo
+  - name: Foo
+    description: All foo operations
+paths:
+  /foo/{id}:
+    get:
+      summary: Returns a single foo
+      operationId: getFoo
+      responses:
+        '200':
+          description: One single Food
+          content:
+            application/json:
+              schema:
+                $ref: './nested/Response.yaml'

__tests__/join/multi-references-to-one-file/nested/FooObject.yaml

@@ -0,0 +1,6 @@
+type: object
+properties:
+  x:
+    type: string
+  y:
+    type: string

__tests__/join/multi-references-to-one-file/nested/Response.yaml

@@ -0,0 +1,14 @@
+type: object
+required:
+  - id
+  - name
+properties:
+  id:
+    type: string
+    format: uuid
+  name:
+    type: string
+  description:
+    type: string
+  subFoo:
+    $ref: './FooObject.yaml'

__tests__/join/multi-references-to-one-file/snapshot.js

@@ -0,0 +1,93 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`E2E join without options test: multi-references-to-one-file 1`] = `
+
+openapi: 3.0.3
+info:
+  title: Sample API
+  description: My sample api
+  version: 0.0.1
+  license:
+    name: Internal
+    url: https://mycompany.com/license
+tags:
+  - name: GetSingleFoo
+    description: Get a single foo
+    x-displayName: GetSingleFoo
+  - name: Foo
+    description: All foo operations
+    x-displayName: Foo
+  - name: foo_other
+    x-displayName: other
+  - name: CreateBar
+    description: Create a new Bar
+    x-displayName: CreateBar
+  - name: bar_other
+    x-displayName: other
+paths:
+  /foo/{id}:
+    get:
+      summary: Returns a single foo
+      operationId: getFoo
+      responses:
+        '200':
+          description: One single Food
+          content:
+            application/json:
+              schema:
+                $ref: '#/components/schemas/Response'
+      tags:
+        - foo_other
+  /bar/:
+    post:
+      summary: Create a single bar
+      operationId: createBar
+      responses:
+        '200':
+          description: One single bar
+          content:
+            application/json:
+              schema:
+                $ref: '#/components/schemas/Response'
+      tags:
+        - bar_other
+components:
+  schemas:
+    FooObject:
+      type: object
+      properties:
+        x:
+          type: string
+        'y':
+          type: string
+    Response:
+      type: object
+      required:
+        - id
+        - name
+      properties:
+        id:
+          type: string
+          format: uuid
+        name:
+          type: string
+        description:
+          type: string
+        subFoo:
+          $ref: '#/components/schemas/FooObject'
+x-tagGroups:
+  - name: foo
+    tags:
+      - GetSingleFoo
+      - Foo
+      - foo_other
+    description: My sample api
+  - name: bar
+    tags:
+      - CreateBar
+      - bar_other
+
+openapi.yaml: join processed in <test>ms
+
+
+`;

packages/cli/src/commands/join.ts

@@ -124,7 +124,7 @@ export async function handleJoin(argv: JoinOptions, config: Config, packageVersi
       bundleDocument({
         document,
         config: config.styleguide,
-        externalRefResolver,
+        externalRefResolver: new BaseResolver(config.resolve),
       }).catch((e) => {
         exitWithError(`${e.message}: ${blue(document.source.absoluteRef)}`);
       })