-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update marked to version 0.6.0 #768
Conversation
30bc62a
to
ec5c0f9
Compare
Opened DefinitelyTyped/DefinitelyTyped#31834 to address the failures, will update accordingly here when possible. |
Updated version for the marked dependency to an official release.
Hi there! Can this PR be merged? What else needs to be reviewed so that this PR can be successfully closed out? I am very much looking forward to this change here: 809e7f2 As I really want to integrate this wonderful open source tool into my project. Thanks so much guys for being such a cool community. |
src/services/MarkdownRenderer.ts
Outdated
@@ -129,7 +131,7 @@ export class MarkdownRenderer { | |||
this.currentTopHeading && this.currentTopHeading.id, | |||
); | |||
} | |||
return this.originalHeadingRule(text, level, raw); | |||
return this.originalHeadingRule(text, level, raw, this.slugger); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you don't need to manually create slugger
.
Just pass it through function parameters:
headingRule = (text: string, level: number, raw: string, slugger: marked.Slugger) => {
// ...
return this.originalHeadingRule(text, level, raw, slugger);
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
Added one comment.
Thanks! |
The new release includes markedjs/marked#1383.
Would it be possible to also release a new version of redoc and redoc-cli?
Thank you.