Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update marked to version 0.6.0 #768

Merged
merged 1 commit into from
Jan 17, 2019

Conversation

lpinca
Copy link
Contributor

@lpinca lpinca commented Jan 2, 2019

The new release includes markedjs/marked#1383.
Would it be possible to also release a new version of redoc and redoc-cli?

Thank you.

@coveralls
Copy link

coveralls commented Jan 2, 2019

Coverage Status

Coverage remained the same at 82.204% when pulling 0d9fcfb on lpinca:update/marked into ab943a8 on Rebilly:master.

@lpinca lpinca force-pushed the update/marked branch 2 times, most recently from 30bc62a to ec5c0f9 Compare January 2, 2019 08:43
@lpinca
Copy link
Contributor Author

lpinca commented Jan 2, 2019

Opened DefinitelyTyped/DefinitelyTyped#31834 to address the failures, will update accordingly here when possible.

softbrix referenced this pull request Jan 4, 2019
Updated version for the marked dependency to an official release.
@ghost
Copy link

ghost commented Jan 4, 2019

Hi there! Can this PR be merged? What else needs to be reviewed so that this PR can be successfully closed out? I am very much looking forward to this change here: 809e7f2

As I really want to integrate this wonderful open source tool into my project. Thanks so much guys for being such a cool community.

@@ -129,7 +131,7 @@ export class MarkdownRenderer {
this.currentTopHeading && this.currentTopHeading.id,
);
}
return this.originalHeadingRule(text, level, raw);
return this.originalHeadingRule(text, level, raw, this.slugger);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you don't need to manually create slugger.
Just pass it through function parameters:

headingRule = (text: string, level: number, raw: string, slugger: marked.Slugger) => {
  // ...
  return this.originalHeadingRule(text, level, raw, slugger);
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, addressed.

Copy link
Member

@RomanHotsiy RomanHotsiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Added one comment.

@RomanHotsiy RomanHotsiy merged commit 02f6e18 into Redocly:master Jan 17, 2019
@RomanHotsiy
Copy link
Member

Thanks!

@lpinca lpinca deleted the update/marked branch January 17, 2019 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants