Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #424: Add onlyRequiredInSamples option #646

Merged
merged 3 commits into from
Oct 5, 2018
Merged

Fix #424: Add onlyRequiredInSamples option #646

merged 3 commits into from
Oct 5, 2018

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Sep 16, 2018

Addresses #424

2018-09-16-93156

@exoego exoego force-pushed the only-required-parameter branch from b3cf819 to 7fb1e90 Compare September 16, 2018 01:32
@exoego exoego changed the title Fix #424: Add skipNonRequired option Fix #424: Add onlyRequiredInSamples option Sep 16, 2018
@exoego exoego force-pushed the only-required-parameter branch from 7fb1e90 to f4f02e9 Compare September 16, 2018 03:43
@coveralls
Copy link

coveralls commented Sep 16, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 81.975% when pulling 57e0d10 on exoego:only-required-parameter into 56ad844 on Rebilly:master.

RomanHotsiy
RomanHotsiy requested changes Oct 4, 2018
View reviewed changes
Copy link
Member

@RomanHotsiy RomanHotsiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one minor comment

Also would be great if you have some time to implement some basic test for this.
If you can't I'd be happy to merge this as is! 👍

src/services/models/MediaType.ts Outdated
@@ -39,12 +41,17 @@ export class MediaTypeModel {
}

generateExample(parser: OpenAPIParser, info: OpenAPIMediaType) {
const samplerOption = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename this to samplerOptions

@RomanHotsiy RomanHotsiy merged commit 10bca66 into Redocly:master Oct 5, 2018
@exoego exoego deleted the only-required-parameter branch October 5, 2018 13:42
@exoego exoego mentioned this pull request Oct 7, 2018
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 29, 2022
Open
@snyk-bot snyk-bot mentioned this pull request May 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomanHotsiy RomanHotsiy RomanHotsiy requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@exoego @coveralls @RomanHotsiy