fix: escape quotes in string values

fixes #882
Redocly · Feb 26, 2019 · 0473165 · 0473165
1 parent 3659a75
commit 0473165
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/utils/jsonToHtml.ts b/src/utils/jsonToHtml.ts
@@ -21,6 +21,10 @@ function htmlEncode(t) {
     : '';
 }
 
+function escapeStringQuotes(str: string) {
+  return str.replace(/"/g, '\\"');
+}
+
 function decorateWithSpan(value, className) {
   return '<span class="' + className + '">' + htmlEncode(value) + '</span>';
 }
@@ -53,11 +57,11 @@ function valueToHTML(value) {
         '<a href="' +
         value +
         '">' +
-        htmlEncode(value) +
+        htmlEncode(escapeStringQuotes(value)) +
         '</a>' +
         decorateWithSpan('"', 'token string');
     } else {
-      output += decorateWithSpan('"' + value + '"', 'token string');
+      output += decorateWithSpan('"' + escapeStringQuotes(value) + '"', 'token string');
     }
   } else if (valueType === 'boolean') {
     output += decorateWithSpan(value, 'token boolean');