Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a webhook to the Museum example #38

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Add a webhook to the Museum example #38

merged 1 commit into from
Oct 17, 2024

Conversation

lornajane
Copy link
Contributor

What/Why/How?

We don't currently have any webhooks in the Museum API and it would be cool to include one!

Check yourself

  • Code is linted
  • Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

HCloward
HCloward approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@HCloward HCloward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lornajane lornajane merged commit 56d2e8f into main Oct 17, 2024
2 checks passed
@lornajane lornajane deleted the add-webhook branch October 17, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HCloward HCloward HCloward approved these changes

@TaylorKrusen TaylorKrusen Awaiting requested review from TaylorKrusen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lornajane @HCloward