Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace deprecated uri-js with uri-js-replace package #24

Merged
merged 6 commits into from
Sep 6, 2024

Conversation

DmitryAnansky
Copy link

What issue does this pull request resolve?

Replace uri-js with uri-js-replace.

uri-js using depricated transitive dependency of punycode package.
Causing warnings like this one:

(node:18708) [DEP0040] DeprecationWarning: The punycode module is deprecated. Please use a userland alternative instead.
(Use node --trace-deprecation ... to show where the warning was created)

What changes did you make?

Is there anything that requires more attention while reviewing?

RomanHotsiy
RomanHotsiy previously approved these changes Sep 6, 2024
@DmitryAnansky DmitryAnansky changed the title fix: replace depricated uri-js with uri-js-replace package fix: replace deprecated uri-js with uri-js-replace package Sep 6, 2024
@DmitryAnansky DmitryAnansky marked this pull request as draft September 6, 2024 13:42
@DmitryAnansky DmitryAnansky marked this pull request as ready for review September 6, 2024 14:05
@DmitryAnansky DmitryAnansky merged commit cb9f743 into master Sep 6, 2024
3 checks passed
@DmitryAnansky DmitryAnansky deleted the fix/replace-uri-js-with-uri-js-replace branch September 6, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants