Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct typo in BLOCK.md #40

Closed
wants to merge 1 commit into from
Closed

correct typo in BLOCK.md #40

wants to merge 1 commit into from

Conversation

jaromil
Copy link

@jaromil jaromil commented Jun 5, 2019

small typo correction in BLOCK.md where RedisModule_IsBlockedTimeoutRequest needs to be called like a function (with ctx as argument) inside the if test.

@itamarhaber
Copy link
Contributor

Yo @jaromil

The docs here are copied (and outdated) from upstream - in this case the redis-doc repo.

@jaromil
Copy link
Author

jaromil commented Jun 6, 2019

hi @itamarhaber! ACK, I see, you mean this file here is the upstream https://github.com/antirez/redis-doc/blob/f2590e156d329cfe801399dc194d3baedfde550b/topics/modules-blocking-ops.md the typo is there too, maybe will refile and in any case refer to @antirez' redis-doc in future

@jaromil
Copy link
Author

jaromil commented Jun 6, 2019

BTW, since I have your attention :^) still a topic about redis modules: would love to have more feedback about this redis/redis#6125 which is vital to the module I'm working on.

@itamarhaber
Copy link
Contributor

WRT redis-doc - yep.
WRT dlopen - I really don't know, but I'll ask the gang to opine.

@gkorland gkorland closed this May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants