Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active-Active Region Application Failover #1034

Merged
merged 7 commits into from
Mar 26, 2021

Conversation

AlonMagrafta
Copy link
Contributor

Yossi and Yuval (Inbar) wrote this doc.
We still need to upload a python script as stated in line 59.
@bmansheim let's coordinate before going live with that one. Thanks

@bmansheim bmansheim added the enhancement Additional information or functionality label Oct 1, 2020
@bmansheim bmansheim added the in progress Changes are in progress label Nov 2, 2020
@bmansheim
Copy link
Contributor

@AlonMagrafta I finished the style review. We just need the Python script in order to be ready to merge, right?

AlonMagrafta and others added 4 commits January 12, 2021 14:09
Yossi and Yuval (Inbar) wrote this doc.
We still need to upload a python script as stated in line 59.
@bmansheim bmansheim removed the in progress Changes are in progress label Jan 12, 2021
@bmansheim bmansheim force-pushed the AlonMagrafta-Region-Application-Failover branch from 699eb45 to d9fa255 Compare January 12, 2021 12:15
@AlonMagrafta AlonMagrafta requested a review from banker January 21, 2021 16:46
@bmansheim bmansheim added blocked More information is required and removed blocked More information is required labels Jan 28, 2021
@bmansheim
Copy link
Contributor

@banker I added the script to the branch but couldn't add it to the page in a way to download nicely.

@kaitlynmichael
Copy link
Contributor

@AlonMagrafta is this something we need to complete before 6.0.20?

@AlonMagrafta
Copy link
Contributor Author

@kaitlynmichael we can do this after 6.0.20, and once it's ready merge and publish, it's not release related

@AlonMagrafta AlonMagrafta requested review from kaitlynmichael and removed request for bmansheim March 15, 2021 09:52
Copy link
Contributor

@kaitlynmichael kaitlynmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reveiwed up to line 50

Note that this document does not suggest that Redis pub/sub is reliable in the common sense. Messages can get lost in certain conditions, but that is acceptable in this case because typically the application determines that replication is down only after not being able to deliver a number of messages over a period of time.
{{< /note >}}

When you use the pub/sub data type to detect failures:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are the instructions for using the pub/sub this way?

@kaitlynmichael kaitlynmichael merged commit 8915223 into master Mar 26, 2021
@kaitlynmichael kaitlynmichael deleted the AlonMagrafta-Region-Application-Failover branch March 26, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Additional information or functionality p_Software
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants