Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break after the first equals result_value to avoid duplicates #29

Merged
merged 3 commits into from
Mar 14, 2022
Merged

Break after the first equals result_value to avoid duplicates #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2525e9
Break after the first equals result_value to avoid duplicates
gkorland Mar 14, 2022
b4b07ee
Add test
gkorland Mar 14, 2022
9035411
Merge branch 'generic_json_path' into gkorland-duplicate
gkorland Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/select/expr_term.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@ where
for result_value in &ret {
if (*map_value).eq(*result_value) {
tmp.push(*rel_value);
break;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can use a label to break from the outer loop to get to the next rel_value?

'outer: for map_value in map.values() {
    for result_value in &ret {
        if map_value.eq(*result_value) {
            tmp.push(*rel_value);
            break 'outer;
        }
    }
}

}
}
}
Expand Down
40 changes: 39 additions & 1 deletion tests/array_filter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,4 +250,42 @@ fn bugs40_bracket_notation_after_recursive_descent() {
"more"
]),
);
}
}

#[test]
fn bugs92_duplicate_result_similar_indernal_values() {
setup();

select_and_then_compare(
"$[?(@.name.first=='A')]",
json!([
{
"name":{
"first":"A"
}
},
{
"name":{
"first":"A"
}
},
{
"name":{
"first":"B"
}
}
]),
json!([
{
"name":{
"first":"A"
}
},
{
"name":{
"first":"A"
}
}
]),
);
}