Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCARD does not show a key field any more #234

Merged
merged 1 commit into from
Nov 10, 2021
Merged

SCARD does not show a key field any more #234

merged 1 commit into from
Nov 10, 2021

Conversation

mikhail-vl
Copy link
Contributor

Fixes #233

@mikhail-vl mikhail-vl added the enhancement New feature or request label Nov 10, 2021
@mikhail-vl mikhail-vl added this to the Version 2.0.0 milestone Nov 10, 2021
@mikhail-vl mikhail-vl self-assigned this Nov 10, 2021
@codecov
Copy link

codecov bot commented Nov 10, 2021 •
edited
Loading

Codecov Report

Merging #234 (ce25973) into master (3ffb8e0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #234   +/-   ##
=======================================
  Coverage   94.75%   94.75%           
=======================================
  Files          39       39           
  Lines        1791     1791           
  Branches       79       79           
=======================================
  Hits         1697     1697           
  Misses         85       85           
  Partials        9        9
Impacted Files Coverage Δ
src/redis/redis.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ffb8e0...ce25973. Read the comment docs.

mikhail-vl
mikhail-vl commented Nov 10, 2021
View reviewed changes
Copy link
Contributor Author

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit dc0c63e into master Nov 10, 2021
@mikhail-vl mikhail-vl deleted the bug/scard-key branch November 10, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mikhail-vl mikhail-vl

Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 2.0.0
Development

Successfully merging this pull request may close these issues.

SCARD does not show a key field any more
1 participant
@mikhail-vl