Exit the isolate before unlcoking it. #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chayim
approved these changes
Jan 17, 2024
MeirShpilraien
added a commit
that referenced
this pull request
Jan 17, 2024
According to the docs and follow the conversation on [this thread](https://groups.google.com/g/v8-dev/c/HssLPoP-pVk/m/lVBlVn9MAgAJ?utm_medium=email&utm_source=footer). The isolate must be exit before using the unlocker and re-entered right after the unlocker is destroyed. This was caught by a recent debug check code that was added [here](https://chromium-review.googlesource.com/c/v8/v8/+/5173257). Fixed the failure on nightly run: https://github.com/RedisGears/RedisGears/actions/runs/7539374024/job/20521749141#step:8:29264 (cherry picked from commit 472ecf6)
MeirShpilraien
added a commit
that referenced
this pull request
Jan 17, 2024
According to the docs and follow the conversation on [this thread](https://groups.google.com/g/v8-dev/c/HssLPoP-pVk/m/lVBlVn9MAgAJ?utm_medium=email&utm_source=footer). The isolate must be exit before using the unlocker and re-entered right after the unlocker is destroyed. This was caught by a recent debug check code that was added [here](https://chromium-review.googlesource.com/c/v8/v8/+/5173257). Fixed the failure on nightly run: https://github.com/RedisGears/RedisGears/actions/runs/7539374024/job/20521749141#step:8:29264 (cherry picked from commit 472ecf6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the docs and follow the conversation on this thread. The isolate must be exit before using the unlocker and re-entered right after the unlocker is destroyed.
This was caught by a recent debug check code that was added here.
Fixed the failure on nightly run: https://github.com/RedisGears/RedisGears/actions/runs/7539374024/job/20521749141#step:8:29264