Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added tls support #32

Merged
merged 7 commits into from
Mar 14, 2022
Merged

added tls support #32

merged 7 commits into from
Mar 14, 2022

Conversation

MeirShpilraien
Copy link
Collaborator

No description provided.

@MeirShpilraien MeirShpilraien mentioned this pull request Feb 27, 2022
Closed
Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes below. Also, You might want to look at adding click-option-groups in order to make the code more maintainable. WDYT?

@MeirShpilraien
Copy link
Collaborator Author

Changes below. Also, You might want to look at adding click-option-groups in order to make the code more maintainable. WDYT?

Its not that popular repository, are we sure we want to use it?

@MeirShpilraien MeirShpilraien requested a review from chayim March 10, 2022 09:46
@MeirShpilraien MeirShpilraien merged commit c0908b9 into master Mar 14, 2022
@MeirShpilraien MeirShpilraien deleted the tls_support branch March 14, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants