Fix label deletion from an unordered map - [MOD-6710]

[GuyAv46]

Describe the changes in the pull request

As stated in the documentation of the unordered map, iterators to an unordered map should be invalidated after reserving memory.

The bug was that we used the iterator we got from find() at the start of the function for deleting the IDs from the index and lastly deleting the label from the map.

Using the iterator returned from the previous lookup might be invalid as we might resize the index while deleting the IDs one by one.

The fix is to use a reference to the ids vector itself in the loop, and finally delete the label from the map using the label and not the iterator.

Mark if applicable

• This PR introduces API changes
• This PR introduces serialization changes

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.39%. Comparing base (182b87a) to head (510d39b).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #435      +/-   ##
==========================================
+ Coverage   95.37%   95.39%   +0.02%     
==========================================
  Files          66       66              
  Lines        4151     4148       -3     
==========================================
- Hits         3959     3957       -2     
+ Misses        192      191       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Backport failed for 0.6, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin 0.6
git worktree add -d .worktree/backport-435-to-0.6 origin/0.6
cd .worktree/backport-435-to-0.6
git switch --create backport-435-to-0.6
git cherry-pick -x 6224f61a0ee38a4df5aa012bc9b15af425242335 3cb3b88d4066c8fa41cf8e45c8f27841c16c2c69 2cc216685db31538404ab91f6fd4da94cf475f13 510d39b8da5abd09dfcb90909e0fc0d891893474

[github-actions]

Successfully created backport PR for 0.7:

• [0.7] Fix label deletion from an unordered map - [MOD-6710] #436