Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Client.Delete() behaves opposite to spec. Deprecates Client.Delete() in favor of Cliente.DeleteDocument() for RediSearch >=v2.0 #80

Merged

Conversation

TropicalPenguin
Copy link
Contributor

@TropicalPenguin TropicalPenguin commented Aug 8, 2020

@filipecosta90 filipecosta90 self-requested a review August 9, 2020 15:23
@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #80 into master will increase coverage by 0.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
+ Coverage   77.06%   77.29%   +0.22%     
==========================================
  Files          13       13              
  Lines        1273     1277       +4     
==========================================
+ Hits          981      987       +6     
+ Misses        232      231       -1     
+ Partials       60       59       -1     
Impacted Files Coverage Δ
redisearch/client.go 79.69% <100.00%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b11c55...50056c3. Read the comment docs.

@filipecosta90 filipecosta90 changed the title Client.Delete() behaves opposite to spec Fixes Client.Delete() behaves opposite to spec. Deprecates Client.Delete() in favor of Cliente.DeleteDocument() for RediSearch >=v2.0 Aug 17, 2020
Copy link
Collaborator

@filipecosta90 filipecosta90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TropicalPenguin thanks you for bringing this up. Took the chance and also added some more tests to it, and deprecated Delete() given that on redisearch >= v2.0 FT.DEL always deletes the underlying document.

@filipecosta90 filipecosta90 merged commit b71ddb1 into RediSearch:master Aug 17, 2020
@TropicalPenguin TropicalPenguin deleted the master-deleteDocument branch August 20, 2020 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client.Delete() behaves opposite to spec for v1.4 and v1.6
2 participants