Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of examples on documentation for NewClient and NewClientFromPool #68

Merged
merged 3 commits into from
May 11, 2020

Conversation

filipecosta90
Copy link
Collaborator

@filipecosta90 filipecosta90 commented May 8, 2020

@filipecosta90 filipecosta90 requested a review from gkorland May 8, 2020 11:11
@filipecosta90 filipecosta90 linked an issue May 8, 2020 that may be closed by this pull request
@gkorland gkorland requested review from itamarhaber and removed request for gkorland May 10, 2020 20:21
@lgtm-com
Copy link

lgtm-com bot commented May 10, 2020

This pull request introduces 1 alert when merging 543495d into 51a0cb3 - view on LGTM.com

new alerts:

  • 1 for Disabled TLS certificate check

@lgtm-com
Copy link

lgtm-com bot commented May 10, 2020

This pull request introduces 1 alert when merging 4624b96 into 51a0cb3 - view on LGTM.com

new alerts:

  • 1 for Disabled TLS certificate check

@lgtm-com
Copy link

lgtm-com bot commented May 10, 2020

This pull request introduces 1 alert when merging a3b8936 into 51a0cb3 - view on LGTM.com

new alerts:

  • 1 for Disabled TLS certificate check

@codecov
Copy link

codecov bot commented May 10, 2020

Codecov Report

Merging #68 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #68   +/-   ##
=======================================
  Coverage   75.27%   75.27%           
=======================================
  Files          12       12           
  Lines        1197     1197           
=======================================
  Hits          901      901           
  Misses        233      233           
  Partials       63       63           
Impacted Files Coverage Δ
redisearch/client.go 80.15% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69202df...163b264. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented May 11, 2020

This pull request introduces 1 alert when merging 7ea24ca into 51a0cb3 - view on LGTM.com

new alerts:

  • 1 for Disabled TLS certificate check

…ntFromPool. Added an example on how to use an SSL Connection with RediSearch.
@lgtm-com
Copy link

lgtm-com bot commented May 11, 2020

This pull request introduces 1 alert when merging 3dd6756 into 51a0cb3 - view on LGTM.com

new alerts:

  • 1 for Disabled TLS certificate check

@filipecosta90
Copy link
Collaborator Author

This pull request introduces 1 alert when merging 3dd6756 into 51a0cb3 - view on LGTM.com

new alerts:

* 1 for Disabled TLS certificate check

@itamarhaber this alert is related to:

InsecureSkipVerify should not be used in production code.

that comes from the SSL connection example, due to InsecureSkipVerify, that is required for the SSL examples to work. Added the following comment:

       // InsecureSkipVerify controls whether a client verifies the
	// server's certificate chain and host name.
	// If InsecureSkipVerify is true, TLS accepts any certificate
	// presented by the server and any host name in that certificate.
	// In this mode, TLS is susceptible to man-in-the-middle attacks.
	// This should be used only for testing.

@lgtm-com
Copy link

lgtm-com bot commented May 11, 2020

This pull request introduces 1 alert when merging 248b636 into 69202df - view on LGTM.com

new alerts:

  • 1 for Disabled TLS certificate check

@lgtm-com
Copy link

lgtm-com bot commented May 11, 2020

This pull request introduces 1 alert when merging 163b264 into 69202df - view on LGTM.com

new alerts:

  • 1 for Disabled TLS certificate check

Copy link
Contributor

@itamarhaber itamarhaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good that you're testing the example :_

@filipecosta90
Copy link
Collaborator Author

Good that you're testing the example :_

=)

@gkorland gkorland merged commit fe2e9b4 into master May 11, 2020
@gkorland gkorland deleted the examples branch May 11, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for passing authentication options to redigo
3 participants