-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of examples on documentation for NewClient and NewClientFromPool #68
Conversation
filipecosta90
commented
May 8, 2020
•
edited
Loading
edited
- ensures that our users will have a quick way of knowing how to connect in a more advanced manner ( see Support for passing authentication options to redigo #67 )
- Added an example on how to use an SSL Connection with RediSearch
- Add the example from here ( and fixes it ): https://github.com/RediSearch/RediSearch/blob/master/docs/go_client.md
- Ensures we're testing with redisearch:edge instead of latest
This pull request introduces 1 alert when merging 543495d into 51a0cb3 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 4624b96 into 51a0cb3 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging a3b8936 into 51a0cb3 - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
=======================================
Coverage 75.27% 75.27%
=======================================
Files 12 12
Lines 1197 1197
=======================================
Hits 901 901
Misses 233 233
Partials 63 63
Continue to review full report at Codecov.
|
This pull request introduces 1 alert when merging 7ea24ca into 51a0cb3 - view on LGTM.com new alerts:
|
…ntFromPool. Added an example on how to use an SSL Connection with RediSearch.
This pull request introduces 1 alert when merging 3dd6756 into 51a0cb3 - view on LGTM.com new alerts:
|
@itamarhaber this alert is related to:
that comes from the SSL connection example, due to
|
This pull request introduces 1 alert when merging 248b636 into 69202df - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 163b264 into 69202df - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good that you're testing the example :_
=) |