Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add AS to fields and new test to check FT.SERCH after JSON.SET #115

Merged
merged 18 commits into from
Jul 21, 2021
Merged

add AS to fields and new test to check FT.SERCH after JSON.SET #115

merged 18 commits into from
Jul 21, 2021

Conversation

AvitalFineRedis
Copy link
Contributor

No description provided.

@gkorland gkorland requested a review from filipecosta90 July 1, 2021 14:04
@codecov
Copy link

codecov bot commented Jul 6, 2021 •
edited
Loading

Codecov Report

Merging #115 (da15ece) into master (7ea2f1d) will increase coverage by 0.13%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
+ Coverage   77.89%   78.03%   +0.13%     
==========================================
  Files          13       13              
  Lines        1312     1320       +8     
==========================================
+ Hits         1022     1030       +8     
  Misses        231      231              
  Partials       59       59
Impacted Files Coverage Δ
redisearch/schema.go 86.70% <75.00%> (-0.63%) ⬇️
redisearch/client.go 81.64% <0.00%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ea2f1d...da15ece. Read the comment docs.

@AvitalFineRedis AvitalFineRedis marked this pull request as ready for review July 6, 2021 07:17
@AvitalFineRedis AvitalFineRedis requested a review from chayim July 6, 2021 07:17
chayim
chayim reviewed Jul 8, 2021
View reviewed changes
redisearch/client_test.go Outdated Show resolved Hide resolved
chayim
chayim suggested changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline test change.

@AvitalFineRedis AvitalFineRedis requested a review from chayim July 11, 2021 14:36
@AvitalFineRedis AvitalFineRedis changed the title add new test to check FT.SERCH after JSON.SET add AS to fields and new test to check FT.SERCH after JSON.SET Jul 19, 2021
chayim
chayim reviewed Jul 20, 2021
View reviewed changes
redisearch/client_test.go Outdated Show resolved Hide resolved
chayim
chayim suggested changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending a small change. It's not vital.

@AvitalFineRedis AvitalFineRedis requested a review from chayim July 20, 2021 13:43
@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AvitalFineRedis AvitalFineRedis merged commit e0864a7 into master Jul 21, 2021
@AvitalFineRedis AvitalFineRedis deleted the json_index_continue branch July 21, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chayim chayim chayim approved these changes

@filipecosta90 filipecosta90 Awaiting requested review from filipecosta90

Assignees

@chayim chayim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AvitalFineRedis @chayim @rafie @gkorland