Skip to content

Commit

Permalink
lint fixes for fake_installer_rpm role
Browse files Browse the repository at this point in the history
  • Loading branch information
evgeni committed Sep 1, 2023
1 parent 9306732 commit af19a6b
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
12 changes: 6 additions & 6 deletions roles/fake_installer_rpm/molecule/satellite/verify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,18 @@
hosts: all
gather_facts: false
tasks:
- name: satellite-installer RPM can be installed
package:
- name: Install satellite-installer RPM
ansible.builtin.package:
name: satellite-installer
state: present

- name: find satellite-installer symlink
stat:
- name: Find satellite-installer symlink
ansible.builtin.stat:
path: /usr/sbin/satellite-installer
register: satellite_installer

- name: check satellite-installer symlink exists
assert:
- name: Check satellite-installer symlink exists
ansible.builtin.assert:
that:
- satellite_installer.stat.exists
- satellite_installer.stat.islnk
4 changes: 2 additions & 2 deletions roles/fake_installer_rpm/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
ansible.builtin.template:
src: satellite-installer.spec.j2
dest: "{{ ansible_env.HOME }}/rpmbuild/SPECS/satellite-installer.spec"
mode: 0644
mode: '0644'

- name: Build satellite-installer RPM

Check failure on line 20 in roles/fake_installer_rpm/tasks/main.yml

View workflow job for this annotation

GitHub Actions / lint

var-naming[pattern]

Variables names should match ^(__)?satellite_\[a-z_]\[a-z0-9_]*$ regex. (build_result) (register: build_result)

Check failure on line 20 in roles/fake_installer_rpm/tasks/main.yml

View workflow job for this annotation

GitHub Actions / lint

var-naming[pattern]

Variables names should match ^(__)?satellite_\[a-z_]\[a-z0-9_]*$ regex. (build_result) (register: build_result)
ansible.builtin.shell: "rpmbuild -ba SPECS/satellite-installer.spec" # noqa command-instead-of-shell
Expand All @@ -31,7 +31,7 @@
src: "{{ ansible_env.HOME }}/rpmbuild/RPMS/x86_64/"
dest: "{{ fake_installer_rpm_repo }}"
remote_src: true
mode: 0644
mode: '0644'
tags:
- molecule-idempotence-notest

Expand Down

0 comments on commit af19a6b

Please sign in to comment.