Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support of Satellite 6.2 (and some more improvements) #1

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

ericzolf
Copy link

Hi,

sorry, it's a quite extensive pull request but the differences between 6.1 and 6.2 were quite important.

I also took the change to do some few minor improvements as I went through the code, if I remember well:

  • replace inclusion of firewall tasks via when through a variable driven inclusion (to avoid skipped tasks)
  • add a satellite_version variable to drive the differences
  • give the registration step a configurable pool pattern
  • make the subscription-manager call with pool-IDs idempotent (yeah!)

Hope this helps,
Eric

@gothicx
Copy link

gothicx commented Mar 9, 2018

It would be great if someone from RedHat could review and approve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants