Support Rails 7.0 #97
Conversation
ofedoren
force-pushed
the
support-rails-7
branch
3 times, most recently
from
89ac933 to
f063521
Compare
ofedoren
force-pushed
the
support-rails-7
branch
from
f063521 to
ccac07b
Compare
| @@ -7,8 +7,9 @@ module RealmTheme | |||
| Realm.class_eval do | |||
| _validators.delete(:realm_type) | |||
| _validate_callbacks.each do |callback| | |||
| if callback.raw_filter.respond_to? :attributes | |||
| callback.raw_filter.attributes.delete :realm_type | |||
| filter_method = callback.respond_to?(:raw_filter) ? :raw_filter : :filter | |||
There was a problem hiding this comment.
What's the difference here? Is this something for compatibility with old/new versions that we can drop at some point?
There was a problem hiding this comment.
Yeap, that's just for the compatibility. Although, we tend to require Foreman version in engines, I'd say we don't even need callback.respond_to?(:raw_filter) compatibility fix, just bump required version to >= 3.14 and use filter right away.
raw_filter was removed in Rails 7, filter seems to be the same:
There was a problem hiding this comment.
6.1 aliases raw_filter to filter, so we can use that already and don't have to do anything special here? Or am I reading the links wrong? 6.1 has been a requirement for a long time.
There was a problem hiding this comment.
Reading the code, I see for 6.1:
def filter; @key; end
def raw_filter; @filter; endAnd 7.0:
attr_reader :chain_config, :filterSo 6.1 has filter read @key while 7.0 reads @filter. In other words, filter changes behavior between the versions.
There was a problem hiding this comment.
🤯
Did I mention how much I like Rails?
ofedoren
force-pushed
the
support-rails-7
branch
from
ccac07b to
9a30720
Compare
There was a problem hiding this comment.
I'm good with the compatibility approach, though I'd appreciate a code comment above it mentioning it's for Rails 6.1 & 7.0 compatibility so if we forget and later see it that we easily know.
@evgeni what do you prefer? hard cut or compatibility?
The filter method thing is the only one, right? Then I'd go with compat as it doesn't seem super complex. |
No description provided.