Update ansible docs according to docs.theforeman.org/nightly urls #45
Conversation
| 'ImportingRoles' => "#{ForemanThemeSatellite.documentation_root}/managing_configurations_using_ansible_integration_in_red_hat_satellite/getting_started_with_ansible_in_satellite_ansible#Importing_Ansible_Roles_and_Variables_ansible", | ||
| 'Variables' => "#{ForemanThemeSatellite.documentation_root}/managing_configurations_using_ansible_integration_in_red_hat_satellite/getting_started_with_ansible_in_satellite_ansible#Overriding_Ansible_Variables_in_satellite_ansible", |
There was a problem hiding this comment.
I'm not sure if it's a good idea to replace these keys. It's possible that they are coded elsewhere as identifiers and if we remove them, then we lose the connection. But I'll try to find someone who really understands it to ack this.
There was a problem hiding this comment.
It was correct to remove them, because they were removed from the source code.
@girijaasoni please remove the lines again.
There was a problem hiding this comment.
When you're taking the suggestions in theforeman/foreman_ansible#711 I think you'll need to override docs_url in the LinksController. We haven't don't that yet, but it needs to happen.
We already have override for the Although, once the PR gets in, we will need to add |
|
I know why I couldn't find it: I had the master branch checked out, not develop. My bad |
girijaasoni
force-pushed
the
ansible-docs-update
branch
from
b7dd463 to
6e0933d
Compare
girijaasoni
force-pushed
the
ansible-docs-update
branch
from
6e0933d to
ad97f02
Compare
girijaasoni
force-pushed
the
ansible-docs-update
branch
2 times, most recently
from
f886c72 to
fbfdedc
Compare
| 'Managing_Configurations_Ansible' => | ||
| { |
There was a problem hiding this comment.
| 'Managing_Configurations_Ansible' => | |
| { | |
| 'Managing_Configurations_Ansible' => { |
girijaasoni
force-pushed
the
ansible-docs-update
branch
2 times, most recently
from
214c18a to
ba40b0e
Compare
girijaasoni
force-pushed
the
ansible-docs-update
branch
from
ba40b0e to
5eac842
Compare
|
@ekohl LGTM, any last comments? |
Note: The satellite URLs will work for 6.15 or higher :)
Blocked by theforeman/foreman_ansible#711