-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update translations #23
Conversation
@@ -134,252 +153,15 @@ msgstr "" | |||
msgid "(build: %{version})" | |||
msgstr "" | |||
|
|||
#: action_names.rb:2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why these were listed here.
It's a file from Katello (https://github.com/Katello/katello/blob/master/locale/action_names.rb) and I would expect it to be translated there, not here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
foreman-tasks doesn't flag where actions come from. If it's in your activated gems, it gets loaded and put here. We can actually add the file to .gitignore
and I've started doing so in some plugins (in the translations batch I'm about to push).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, interesting, yeah I don't have tasks loaded rn. but probably Bryan did when originally generating this file in 2018.
9d49b1e
to
473ef1c
Compare
473ef1c
to
a87401e
Compare
app/assets/javascripts/foreman_theme_satellite/locale/bn/foreman_theme_satellite.js
Outdated
Show resolved
Hide resolved
a87401e
to
8eff82c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't feel like this is 50% translated. I've found that you can accidentally pull this in at some point. The best is to clean out temporary files before pulling (git clean -xf locale
) because if there's a file locale/cs_CZ
, it will be added. Even if it's below 50%.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
according to TX, it is:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I think the translated things are the ones from actions, that are not actually here anymore, thus TX thinks it's over 50%, while it really is not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
% git grep -c msgstr locale/cs_CZ/foreman_theme_satellite.po
locale/cs_CZ/foreman_theme_satellite.po:35
% git grep -c 'msgstr ""' locale/cs_CZ/foreman_theme_satellite.po
locale/cs_CZ/foreman_theme_satellite.po:29
% git grep -c -E 'msgstr ".+"' locale/cs_CZ/foreman_theme_satellite.po
locale/cs_CZ/foreman_theme_satellite.po:6
this is indeed not 50% 🤷♀️
I wonder what this is about: foreman_theme_satellite/app/overrides/satellite_name_override.rb Lines 1 to 20 in 0598c8f
I don't quite see how these are used, if at all. Not on my laptop so I can't check the downstream history. |
It was added for https://bugzilla.redhat.com/show_bug.cgi?id=1362653 but I don't see how (where) this is used |
going to merge this as-is and then see what transifex does with the removed strings |
No description provided.