Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translations #23

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Update translations #23

merged 2 commits into from
Dec 20, 2023

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Nov 27, 2023

No description provided.

@@ -134,252 +153,15 @@ msgstr ""
msgid "(build: %{version})"
msgstr ""

#: action_names.rb:2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why these were listed here.
It's a file from Katello (https://github.com/Katello/katello/blob/master/locale/action_names.rb) and I would expect it to be translated there, not here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

foreman-tasks doesn't flag where actions come from. If it's in your activated gems, it gets loaded and put here. We can actually add the file to .gitignore and I've started doing so in some plugins (in the translations batch I'm about to push).

Copy link
Member Author

@evgeni evgeni Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, interesting, yeah I don't have tasks loaded rn. but probably Bryan did when originally generating this file in 2018.

@evgeni evgeni force-pushed the update-translations branch 3 times, most recently from 9d49b1e to 473ef1c Compare November 27, 2023 13:49
@evgeni evgeni force-pushed the update-translations branch from 473ef1c to a87401e Compare November 28, 2023 09:49
@evgeni evgeni force-pushed the update-translations branch from a87401e to 8eff82c Compare November 28, 2023 11:53
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't feel like this is 50% translated. I've found that you can accidentally pull this in at some point. The best is to clean out temporary files before pulling (git clean -xf locale) because if there's a file locale/cs_CZ, it will be added. Even if it's below 50%.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to TX, it is:
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I think the translated things are the ones from actions, that are not actually here anymore, thus TX thinks it's over 50%, while it really is not.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

% git grep -c msgstr locale/cs_CZ/foreman_theme_satellite.po
locale/cs_CZ/foreman_theme_satellite.po:35
% git grep -c 'msgstr ""' locale/cs_CZ/foreman_theme_satellite.po 
locale/cs_CZ/foreman_theme_satellite.po:29
% git grep -c -E 'msgstr ".+"' locale/cs_CZ/foreman_theme_satellite.po
locale/cs_CZ/foreman_theme_satellite.po:6

this is indeed not 50% 🤷‍♀️

@ekohl
Copy link
Contributor

ekohl commented Nov 28, 2023

I wonder what this is about:

# Add in the localizatione below to make sure they are extracted.
N_("Version %{version}")
N_("Support")
N_("Customer portal")
N_("Documentation")
N_('Administering Red Hat Satellite')
N_('Transitioning from Red Hat Satellite 5 to Red Hat Satellite 6')
N_("API Guide")
N_("Blog")
N_('Red Hat Satellite Blog')
N_("IRC")
N_("You can find us on %{liberachat} (irc.libera.chat) in #redhat-satellite.")
N_("Version %{version} © %{year} Red Hat Inc.")
N_("Includes %{system} © 2009-%{year} Paul Kelly and Ohad Levy")
N_("If you feel this is an error with Satellite 6 itself, please open a new issue with")
N_("Satellite ticketing system")
N_("You would probably need to attach the")
N_("Full trace")
N_("and relevant log entries.")
N_("(build: %{version})")

I don't quite see how these are used, if at all. Not on my laptop so I can't check the downstream history.

@evgeni
Copy link
Member Author

evgeni commented Nov 28, 2023

It was added for https://bugzilla.redhat.com/show_bug.cgi?id=1362653 but I don't see how (where) this is used

@evgeni
Copy link
Member Author

evgeni commented Dec 20, 2023

going to merge this as-is and then see what transifex does with the removed strings

@evgeni evgeni merged commit 334fba6 into develop Dec 20, 2023
5 checks passed
@evgeni evgeni deleted the update-translations branch December 20, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants