Use the return of the conditional for variable assignment and comparison

RedHatSatellite · Jul 17, 2024 · 75852c8 · 75852c8
1 parent 090a0a3
commit 75852c8
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/app/controllers/concerns/documentation_controller_branding.rb b/app/controllers/concerns/documentation_controller_branding.rb
@@ -12,11 +12,11 @@ def documentation_url(section = nil, options = {})
     end
     if url.empty?
       upstream_url = super(section, options)
-      if (upstream_url =~ /redhat.com/)
-        url = upstream_url
-      else
-        url = "#{ForemanThemeSatellite.documentation_root}/administering_red_hat_satellite"
-      end
+      url = if (upstream_url =~ /redhat.com/)
+              upstream_url
+            else
+              "#{ForemanThemeSatellite.documentation_root}/administering_red_hat_satellite"
+            end
     end
     url
   end