Enable compile-time default facts file #301
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By way of a new build option, default_facts_file, enable a compile-time default value for the facts-file flag. The RPMs built out of `dist/srpm` are updated to build with this value set to /var/lib/yggdrasil/canonical-facts.json.
subpop
force-pushed
the
compile-time-default-facts-file
branch
from
521e103 to
8e0646a
Compare
|
Tagging @Archana-PandeyM for QE review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By way of a new build option, default_facts_file, enable a compile-time default value for the facts-file flag. The RPMs built out of
dist/srpmare updated to build with this value set to /var/lib/yggdrasil/canonical-facts.json.To verify this behavior, make sure that the line defining
facts-fileis removed or commented out from your config file (/etc/yggdrasil/config.toml). Runningyggdrasil.servicefrom this branch on a fully registered system should still find the file/var/lib/yggdrasil/canonical-facts.json.If you connect your yggdrasil to a local broker, you can subscribe to its topics and confirm that facts are still published in the "connection-status" message. Otherwise, connecting your yggdrasil to connect.cloud.stage.redhat.com means you'll have to either scour Kibana logs for your messages being received by cloud-connector or assume that facts got there.
The local yggdrasil logs should not report any errors about a missing facts file.
Card ID: CCT-1164