fix golangci-lint findings

logger/logger.go

@@ -45,7 +45,11 @@ func InitLogger() *zap.Logger {
 
 		logger, _ := loggerConfig.Build(options...)
 
-		defer logger.Sync()
+		defer func() {
+			if err := logger.Sync(); err != nil {
+				fmt.Printf("Failed to sync logger: %v", err)
+			}
+		}()
 		Log = logger
 	}
 

requests/cluster/cluster.go

@@ -5,19 +5,10 @@ import (
 	"fmt"
 	"net/http"
 
-	l "github.com/redhatinsights/uhc-auth-proxy/logger"
 	"github.com/redhatinsights/uhc-auth-proxy/requests/client"
 	"github.com/spf13/viper"
-	"go.uber.org/zap"
 )
 
-var log *zap.Logger
-
-func init() {
-	l.InitLogger()
-	log = l.Log.Named("cluster")
-}
-
 // GetIdentity is a facade over all the steps required to get an Identity
 func GetIdentity(wrapper client.Wrapper, reg Registration) (*Identity, error) {
 

server/server.go

@@ -160,7 +160,10 @@ func RootHandler(wrapper client.Wrapper) func(w http.ResponseWriter, r *http.Req
 
 		w.Header().Add("Content-Type", "application/json")
 		respond(200)
-		w.Write(out)
+		_, err = w.Write(out)
+		if err != nil {
+			logr.Error("failed to write response", zap.Error(err))
+		}
 	}
 }
 
@@ -186,7 +189,10 @@ func getErrorStatusCode(err error) int {
 
 // StatusHandler handles a basic /status endpoint for information/ready checks
 func StatusHandler(w http.ResponseWriter, r *http.Request) {
-	json.NewEncoder(w).Encode(map[string]string{"status": "available"})
+	err := json.NewEncoder(w).Encode(map[string]string{"status": "available"})
+	if err != nil {
+		log.Error(fmt.Sprintf("Failed to encode response: %v", err))
+	}
 }
 
 // Start starts the server

server/server_test.go

@@ -70,7 +70,7 @@ func call(wrapper client.Wrapper, userAgent string, auth string) (*httptest.Resp
 	Expect(err).To(BeNil())
 	rr.Result().Body.Close()
 	var ident cluster.Identity
-	json.Unmarshal(out, &ident)
+	_ = json.Unmarshal(out, &ident)
 	return rr, &ident
 }