[RHCLOUD-33471] Update logic on complex status objects #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlakeHolifield
force-pushed
the
RHCLOUD-33471-unit-test
branch
from
466f67b to
a9d9014
Compare
Hyperkid123
reviewed
Jul 15, 2024
src/common/pdfCache.spec.ts
Outdated
| pdfCache.verifyCollection(noeExpId); | ||
| const noLen = pdfCache.getCollection(noeExpId); | ||
| console.log(noLen); | ||
| console.log(noLen.expectedLength); |
There was a problem hiding this comment.
I don't think we need these
BlakeHolifield
force-pushed
the
RHCLOUD-33471-unit-test
branch
from
a9d9014 to
035f7bf
Compare
BlakeHolifield
requested review from
Hyperkid123,
florkbr,
aneelac22 and
apinkert
BlakeHolifield
force-pushed
the
RHCLOUD-33471-unit-test
branch
from
035f7bf to
fa7c77d
Compare
Hyperkid123
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GeneratedandFailedare consistent