notifications api client tests #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catastrophe-brandon
force-pushed
the
btweed/notifications-tests
branch
3 times, most recently
from
46fbfda to
d591f71
Compare
catastrophe-brandon
force-pushed
the
btweed/notifications-tests
branch
3 times, most recently
from
d963669 to
ab8b97e
Compare
catastrophe-brandon
force-pushed
the
btweed/notifications-tests
branch
from
ab8b97e to
6616c49
Compare
florkbr
reviewed
Jan 14, 2025
| @@ -47,6 +47,27 @@ | |||
| "commitMessageFormat": "release: bump {projectName} to {version} [skip ci]" | |||
| } | |||
| }, | |||
| "integration-v2": { | |||
There was a problem hiding this comment.
@catastrophe-brandon not blocking; but in the future I wonder if we can parameterize these to accept v1 or v2 etc to reduce duplication in the project.json and downstream. In reality I'm not sure how many versions of APIs we will really have at any given time, but I don't want this to get out of hand.
florkbr
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #341.
Establishes test coverage for Notifications API v1 and v2.