Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHAINSAW-234 Add rhsm.environments to schema #145

Merged

Conversation

Tomboyo
Copy link
Contributor

@Tomboyo Tomboyo commented Dec 4, 2024

Adds the rhsm.environments field to the schema. See associated change to insights-host-inventory, RedHatInsights/insights-host-inventory#2112, which reflects these changes there per the contrib section of the README.

@Tomboyo Tomboyo marked this pull request as ready for review December 4, 2024 21:52
@Tomboyo Tomboyo requested a review from a team as a code owner December 4, 2024 21:52
@dippy-bot
Copy link
Collaborator

Here are the System Profile validation results using Prod data.
Validating against the RedHatInsights/inventory-schemas master spec:

puptoo:
	Pass: 141655
	Fail: 0

cloud-connector:
	Pass: 18465
	Fail: 0

satellite:
	Pass: 214510
	Fail: 2

rhsm-system-profile-bridge:
	Pass: 73367
	Fail: 1

rhsm-conduit:
	Pass: 52000
	Fail: 0


Validating against this PR's spec:

puptoo:
	Pass: 141655
	Fail: 0

cloud-connector:
	Pass: 18465
	Fail: 0

satellite:
	Pass: 214510
	Fail: 2

rhsm-system-profile-bridge:
	Pass: 73367
	Fail: 1

rhsm-conduit:
	Pass: 52000
	Fail: 0


@dippy-bot
Copy link
Collaborator

Here are the System Profile validation results using Prod data.
Validating against the RedHatInsights/inventory-schemas master spec:

puptoo:
	Pass: 150379
	Fail: 0

cloud-connector:
	Pass: 6614
	Fail: 0

satellite:
	Pass: 170511
	Fail: 0

rhsm-system-profile-bridge:
	Pass: 170384
	Fail: 0

rhsm-conduit:
	Pass: 2112
	Fail: 0


Validating against this PR's spec:

puptoo:
	Pass: 150379
	Fail: 0

cloud-connector:
	Pass: 6614
	Fail: 0

satellite:
	Pass: 170511
	Fail: 0

rhsm-system-profile-bridge:
	Pass: 170384
	Fail: 0

rhsm-conduit:
	Pass: 2112
	Fail: 0


@dippy-bot
Copy link
Collaborator

Here are the System Profile validation results using Prod data.
Validating against the RedHatInsights/inventory-schemas master spec:

puptoo:
	Pass: 125556
	Fail: 1

cloud-connector:
	Pass: 2555
	Fail: 0

satellite:
	Pass: 209742
	Fail: 2

rhsm-conduit:
	Pass: 97114
	Fail: 0

rhsm-system-profile-bridge:
	Pass: 65029
	Fail: 1


Validating against this PR's spec:

puptoo:
	Pass: 125556
	Fail: 1

cloud-connector:
	Pass: 2555
	Fail: 0

satellite:
	Pass: 209742
	Fail: 2

rhsm-conduit:
	Pass: 97114
	Fail: 0

rhsm-system-profile-bridge:
	Pass: 65029
	Fail: 1


@Tomboyo Tomboyo force-pushed the chainsaw-234-include-environment branch from fe76bb3 to 70c5363 Compare December 17, 2024 15:03
Copy link
Contributor

@kruai kruai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tomboyo Looks good, but can we set a max length for the field? I was going to suggest 32 because of the examples, but one of your tests in valids has a longer string

@Tomboyo
Copy link
Contributor Author

Tomboyo commented Dec 23, 2024

@Tomboyo Looks good, but can we set a max length for the field? I was going to suggest 32 because of the examples, but one of your tests in valids has a longer string

@Ceiu Right now the Insights schema treats environment (UU)IDs as opaque tokens without any specific format beyond being strings. Is there a maximum length we could enforce for the IDs, per Kruai's question? I think this would be used to reject malicious input, is that right @kruai ? In which case, this doesn't have to track closely with whatever the ID is implemented as, just be a tentative upper bound on how long it might be in the near future.

@Tomboyo
Copy link
Contributor Author

Tomboyo commented Jan 7, 2025

@kruai I reached out to ceiu over slack and we landed on a maxLength of 256 to balance between hiding impl details from the schema and giving a reasonable upper-bound length. Let me know if that sounds good to you as well. Thanks.

@dippy-bot
Copy link
Collaborator

Here are the System Profile validation results using Prod data.
Validating against the RedHatInsights/inventory-schemas master spec:

puptoo:
	Pass: 124510
	Fail: 0

cloud-connector:
	Pass: 4467
	Fail: 0

satellite:
	Pass: 254114
	Fail: 1

rhsm-conduit:
	Pass: 100601
	Fail: 0

rhsm-system-profile-bridge:
	Pass: 16307
	Fail: 0


Validating against this PR's spec:

puptoo:
	Pass: 124510
	Fail: 0

cloud-connector:
	Pass: 4467
	Fail: 0

satellite:
	Pass: 254114
	Fail: 1

rhsm-conduit:
	Pass: 100601
	Fail: 0

rhsm-system-profile-bridge:
	Pass: 16307
	Fail: 0


Copy link
Contributor

@kruai kruai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tomboyo that sounds good to me. @thearifismail are you OK with me merging this?

@kruai kruai merged commit 79b90a0 into RedHatInsights:master Jan 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants