Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link(s) to Jira
Description of Intent of Change(s)
The fs-extra causes failure of buiding openapi. According to this:
google/docsy#265, node version will fix this
Failure message looks like this:
/opt/app-root/src/.npm-global/lib/node_modules/apidoc/node_modules/fs-extra/lib/mkdirs/make-dir.js:85
} catch {
^
SyntaxError: Unexpected token {
at createScript (vm.js:80:10)
at Object.runInThisContext (vm.js:139:10)
at Module._compile (module.js:617:28)
at Object.Module._extensions..js (module.js:664:10)
at Module.load (module.js:566:32)
at tryModuleLoad (module.js:506:12)
at Function.Module._load (module.js:498:3)
at Module.require (module.js:597:17)
at require (internal/module.js:11:18)
at Object. (/opt/app-root/src/.npm-global/lib/node_modules/apidoc/node_modules/fs-extra/lib/mkdirs/index.js:3:44)
make: *** [gen-apidoc] Error 1
Local Testing
How can the feature be exercised?
How can the bug be exploited and fix confirmed?
Is any special local setup required?
Checklist
if API spec changes are required, is the spec updated?
are there any pre/post merge actions required? if so, document here.
are theses changes covered by unit tests?
if warranted, are documentation changes accounted for?
does this require migration changes?
Yea, we could easily roll this back
is there known, direct impact to dependent teams/components?