Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrate node version from 8 to 10 #329

Merged
merged 1 commit into from
Aug 20, 2020

Conversation

astrozzc
Copy link
Contributor

@astrozzc astrozzc commented Aug 20, 2020

Link(s) to Jira

Description of Intent of Change(s)

The fs-extra causes failure of buiding openapi. According to this:
google/docsy#265, node version will fix this

Failure message looks like this:
/opt/app-root/src/.npm-global/lib/node_modules/apidoc/node_modules/fs-extra/lib/mkdirs/make-dir.js:85
} catch {
^

SyntaxError: Unexpected token {
at createScript (vm.js:80:10)
at Object.runInThisContext (vm.js:139:10)
at Module._compile (module.js:617:28)
at Object.Module._extensions..js (module.js:664:10)
at Module.load (module.js:566:32)
at tryModuleLoad (module.js:506:12)
at Function.Module._load (module.js:498:3)
at Module.require (module.js:597:17)
at require (internal/module.js:11:18)
at Object. (/opt/app-root/src/.npm-global/lib/node_modules/apidoc/node_modules/fs-extra/lib/mkdirs/index.js:3:44)
make: *** [gen-apidoc] Error 1

Local Testing

How can the feature be exercised?
How can the bug be exploited and fix confirmed?
Is any special local setup required?

Checklist

  • if API spec changes are required, is the spec updated?

  • are there any pre/post merge actions required? if so, document here.

  • are theses changes covered by unit tests?

  • if warranted, are documentation changes accounted for?

  • does this require migration changes?

    • if yes, are they backwards compatible?
      Yea, we could easily roll this back
  • is there known, direct impact to dependent teams/components?

    • if yes, how will this be handled?

@astrozzc astrozzc requested a review from wcmitchell August 20, 2020 16:41
@codecov-commenter
Copy link

Codecov Report

Merging #329 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #329   +/-   ##
======================================
  Coverage    90.8%   90.8%           
======================================
  Files          52      52           
  Lines        2124    2124           
  Branches      277     277           
======================================
  Hits         1928    1928           
  Misses        132     132           
  Partials       64      64           

The fs-extra causes failure of buiding openapi. According to this:
google/docsy#265, node version will fix this
Copy link
Contributor

@wcmitchell wcmitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems worth a shot to move past these errors. We can back it out if we notice any negatives, but local testing seems to indicate this will allow the apidocs to be built

@astrozzc astrozzc merged commit 1ff096a into RedHatInsights:master Aug 20, 2020
@astrozzc astrozzc deleted the upgrade_node branch August 20, 2020 17:28
@wcmitchell wcmitchell added this to the Sprint 20 Milestone milestone Aug 20, 2020
lpichler pushed a commit that referenced this pull request Nov 8, 2023
…bump

Bump version of rbac stage role back down
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants