[RHCLOUD-37288] add the 'user' as default value for the 'type' query parameter and 'GET /principals/' #1503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petracihalova
force-pushed
the
default_type
branch
from
3ae3e0e to
fdc04d3
Compare
petracihalova
force-pushed
the
default_type
branch
from
fdc04d3 to
c630b77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RHCLOUD-37288
existing behavior will not be changed
GET /principals/= the default valueuserfor query param 'type' is used = only user based principals listed in the responseGET /principals/?type=user= only user based principals listed in the responseGET /principals/?type=service-account= only service account based principals listed in the responsethis PR only adds the default value for the
typequery param validation ... I need this in the next PR that will introduce theallvalue