Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RHCLOUD-37774] /principals/ view refactoring #1502

Merged
merged 2 commits into from
Feb 10, 2025
Merged

[RHCLOUD-37774] /principals/ view refactoring #1502

merged 2 commits into from
Feb 10, 2025

Conversation

petracihalova
Copy link
Contributor

@petracihalova petracihalova commented Feb 10, 2025 •
edited
Loading

RHCLOUD-37774

move the options creation out the try block as it is unrelated to the caught exception

and

move offset for the previous link creation closer to the links logic

@petracihalova petracihalova changed the title /principals/ view refactoring [RHCLOUD-37774] /principals/ view refactoring Feb 10, 2025
@lpichler lpichler merged commit e95aeb9 into RedHatInsights:master Feb 10, 2025
11 checks passed
@petracihalova petracihalova deleted the principals-refactoring branch February 10, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpichler lpichler lpichler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petracihalova @lpichler