-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add arg to capture skips in the broker #3663
Merged
bfahr
merged 1 commit into
RedHatInsights:master
from
ryan-blakley:add_arg_to_see_skips
Jan 31, 2023
Merged
feat: Add arg to capture skips in the broker #3663
bfahr
merged 1 commit into
RedHatInsights:master
from
ryan-blakley:add_arg_to_see_skips
Jan 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jholecek-rh
reviewed
Jan 25, 2023
jholecek-rh
reviewed
Jan 25, 2023
* Added the --show-skips cli arg to trigger SkipComponents to be captured in the broker for troubleshooting purposes. Signed-off-by: Ryan Blakley <[email protected]>
xiangce
approved these changes
Jan 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current version looks good to me.
bfahr
pushed a commit
that referenced
this pull request
Jan 31, 2023
* Added the --show-skips cli arg to trigger SkipComponents to be captured in the broker for troubleshooting purposes. Signed-off-by: Ryan Blakley <[email protected]> (cherry picked from commit 1979385)
3 tasks
xiangce
pushed a commit
that referenced
this pull request
Mar 16, 2023
PR #3663 added a `Broker.store_skips` attribute that allows for storing `SkipComponent` exceptions in the broker. This commit makes the feature available in tests based on the `run_input_data` function. Signed-off-by: Jan Holeček <[email protected]>
xiangce
pushed a commit
that referenced
this pull request
Mar 16, 2023
PR #3663 added a `Broker.store_skips` attribute that allows for storing `SkipComponent` exceptions in the broker. This commit makes the feature available in tests based on the `run_input_data` function. Signed-off-by: Jan Holeček <[email protected]> (cherry picked from commit 35b8b2d)
xiangce
pushed a commit
that referenced
this pull request
Sep 6, 2024
* Added the --show-skips cli arg to trigger SkipComponents to be captured in the broker for troubleshooting purposes. Signed-off-by: Ryan Blakley <[email protected]>
xiangce
pushed a commit
that referenced
this pull request
Sep 6, 2024
PR #3663 added a `Broker.store_skips` attribute that allows for storing `SkipComponent` exceptions in the broker. This commit makes the feature available in tests based on the `run_input_data` function. Signed-off-by: Jan Holeček <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply:
Complete Description of Additions/Changes:
Added the --show-skips cli arg to trigger SkipComponents to be captured in the broker for troubleshooting purposes.