Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add arg to capture skips in the broker #3663

Merged
merged 1 commit into from
Jan 31, 2023
Merged

feat: Add arg to capture skips in the broker #3663

merged 1 commit into from
Jan 31, 2023

Conversation

ryan-blakley
Copy link
Contributor

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

Added the --show-skips cli arg to trigger SkipComponents to be captured in the broker for troubleshooting purposes.

@ryan-blakley ryan-blakley requested a review from xiangce January 24, 2023 19:19
insights/__init__.py Outdated Show resolved Hide resolved
insights/core/dr.py Outdated Show resolved Hide resolved
* Added the --show-skips cli arg to trigger SkipComponents to be
  captured in the broker for troubleshooting purposes.

Signed-off-by: Ryan Blakley <[email protected]>
Copy link
Contributor

@xiangce xiangce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current version looks good to me.

@bfahr bfahr merged commit 1979385 into RedHatInsights:master Jan 31, 2023
bfahr pushed a commit that referenced this pull request Jan 31, 2023
* Added the --show-skips cli arg to trigger SkipComponents to be
  captured in the broker for troubleshooting purposes.

Signed-off-by: Ryan Blakley <[email protected]>
(cherry picked from commit 1979385)
xiangce pushed a commit that referenced this pull request Mar 16, 2023
PR #3663 added a `Broker.store_skips` attribute that allows for storing
`SkipComponent` exceptions in the broker. This commit makes the feature
available in tests based on the `run_input_data` function.

Signed-off-by: Jan Holeček <[email protected]>
xiangce pushed a commit that referenced this pull request Mar 16, 2023
PR #3663 added a `Broker.store_skips` attribute that allows for storing
`SkipComponent` exceptions in the broker. This commit makes the feature
available in tests based on the `run_input_data` function.

Signed-off-by: Jan Holeček <[email protected]>
(cherry picked from commit 35b8b2d)
xiangce pushed a commit that referenced this pull request Sep 6, 2024
* Added the --show-skips cli arg to trigger SkipComponents to be
  captured in the broker for troubleshooting purposes.

Signed-off-by: Ryan Blakley <[email protected]>
xiangce pushed a commit that referenced this pull request Sep 6, 2024
PR #3663 added a `Broker.store_skips` attribute that allows for storing
`SkipComponent` exceptions in the broker. This commit makes the feature
available in tests based on the `run_input_data` function.

Signed-off-by: Jan Holeček <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants