Deprecate SkipException to help avoid confusion #3662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfahr
requested changes
Jan 24, 2023
xiangce
requested changes
Jan 31, 2023
|
BTW, this PR breaks the tests of gss and prodsec rules, I raised a MR to resolve the test of gss rules and asked ProdSec team to resolve the prodsec rules as well. |
* Mark SkipException deprecated to help avoid confusion as the dirty parser difference isn't really needed. * Replaced all internal references with SkipComponent. Signed-off-by: Ryan Blakley <[email protected]>
|
@xiangce Another good catch I tested the other projects but forgot about gss-rules. In addition to your PR, I corrected the issue by adding a back import in insights/core/init.py for SkipException. All tests pass for me now on all projects that I know about. |
bfahr
approved these changes
Jan 31, 2023
|
@ryan-blakley Thank you. The PR looks good. Our rule repository won't be affected. We haven't been using |
xiangce
approved these changes
Feb 2, 2023
xiangce
pushed a commit
that referenced
this pull request
Feb 2, 2023
* Mark SkipException deprecated to help avoid confusion as the dirty parser difference isn't really needed. * Replaced all internal references with SkipComponent. Signed-off-by: Ryan Blakley <[email protected]> (cherry picked from commit d46b4eb)
xiangce
pushed a commit
that referenced
this pull request
Sep 6, 2024
* Mark SkipException deprecated to help avoid confusion as the dirty parser difference isn't really needed. * Replaced all internal references with SkipComponent. Signed-off-by: Ryan Blakley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply:
Complete Description of Additions/Changes:
Mark SkipException deprecated to help avoid confusion as the dirty parser difference isn't really needed. Replaced all internal references with SkipComponent.