-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New datasource "sys_fs_cgroup_uniq_memory_swappiness" and its parser #3645
Conversation
@xiangce please help review, thanks! |
@xiangce I updated it to a datasource, please help review, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good, expect for the new introduced typo.
…arser Signed-off-by: Qin Ping <[email protected]>
Signed-off-by: Qin Ping <[email protected]>
Signed-off-by: Qin Ping <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending the approval of Spec
…arser (#3645) * feat: New datasource "sys_fs_cgroup_uniq_memory_swappiness" and its parser Signed-off-by: Qin Ping <[email protected]> * Updated the datasource and its parser per the review comments. Signed-off-by: Qin Ping <[email protected]> * Fix the typo in docstring. Signed-off-by: Qin Ping <[email protected]> (cherry picked from commit c62d7dd)
…arser (#3645) * feat: New datasource "sys_fs_cgroup_uniq_memory_swappiness" and its parser Signed-off-by: Qin Ping <[email protected]> * Updated the datasource and its parser per the review comments. Signed-off-by: Qin Ping <[email protected]> * Fix the typo in docstring. Signed-off-by: Qin Ping <[email protected]>
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
Add your description here
This PR is used to check the memory.swappiness setting under
/sys/fs/cgroup/memory
dir, check the CEECBA-6282 to see the detailed information.