Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New datasource "sys_fs_cgroup_uniq_memory_swappiness" and its parser #3645

Merged
merged 3 commits into from
Jan 12, 2023
Merged

feat: New datasource "sys_fs_cgroup_uniq_memory_swappiness" and its parser #3645

merged 3 commits into from
Jan 12, 2023

Conversation

qinpingli
Copy link
Contributor

@qinpingli qinpingli commented Jan 3, 2023

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

Add your description here
This PR is used to check the memory.swappiness setting under /sys/fs/cgroup/memory dir, check the CEECBA-6282 to see the detailed information.

@qinpingli qinpingli changed the title [WIP]feat: New spec "uniq_memory_swappiness" and its parser feat: New spec "uniq_memory_swappiness" and its parser Jan 3, 2023
@qinpingli
Copy link
Contributor Author

@xiangce please help review, thanks!

@qinpingli qinpingli changed the title feat: New spec "uniq_memory_swappiness" and its parser [WIP]feat: New spec "uniq_memory_swappiness" and its parser Jan 5, 2023
@qinpingli qinpingli changed the title [WIP]feat: New spec "uniq_memory_swappiness" and its parser feat: New spec "uniq_memory_swappiness" and its parser Jan 6, 2023
@qinpingli
Copy link
Contributor Author

@xiangce I updated it to a datasource, please help review, thanks!

@qinpingli qinpingli changed the title feat: New spec "uniq_memory_swappiness" and its parser feat: New datasource "sys_fs_cgroup_uniq_memory_swappiness" and its parser Jan 10, 2023
insights/parsers/sys_fs_cgroup_memory.py Outdated Show resolved Hide resolved
docs/custom_datasources_index.rst Outdated Show resolved Hide resolved
insights/specs/default.py Outdated Show resolved Hide resolved
insights/specs/datasources/sys_fs_cgroup_memory.py Outdated Show resolved Hide resolved
insights/parsers/sys_fs_cgroup_memory.py Outdated Show resolved Hide resolved
Copy link
Contributor

@xiangce xiangce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, expect for the new introduced typo.

insights/parsers/sys_fs_cgroup_memory.py Outdated Show resolved Hide resolved
Copy link
Contributor

@xiangce xiangce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending the approval of Spec

@xiangce xiangce merged commit c62d7dd into RedHatInsights:master Jan 12, 2023
xiangce pushed a commit that referenced this pull request Jan 12, 2023
…arser (#3645)

* feat: New datasource "sys_fs_cgroup_uniq_memory_swappiness" and its parser

Signed-off-by: Qin Ping <[email protected]>

* Updated the datasource and its parser per the review comments.

Signed-off-by: Qin Ping <[email protected]>

* Fix the typo in docstring.

Signed-off-by: Qin Ping <[email protected]>
(cherry picked from commit c62d7dd)
xiangce pushed a commit that referenced this pull request Sep 6, 2024
…arser (#3645)

* feat: New datasource "sys_fs_cgroup_uniq_memory_swappiness" and its parser

Signed-off-by: Qin Ping <[email protected]>

* Updated the datasource and its parser per the review comments.

Signed-off-by: Qin Ping <[email protected]>

* Fix the typo in docstring.

Signed-off-by: Qin Ping <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants