Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpin ipython==8.6.0 for branch 3.0 #3626

Closed
wants to merge 1 commit into from
Closed

unpin ipython==8.6.0 for branch 3.0 #3626

wants to merge 1 commit into from

Conversation

jsvob
Copy link
Member

@jsvob jsvob commented Dec 12, 2022

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

The 3.0 branch is designed to run with Python 3.6. The pinned version of ipython is not compatible with Python 3.6. The pinning makes running pip install -e ".[develop]" impossible. As a result, setting up a fresh development environment is impossible without removing the pin. I'm not sure whether #3615 was meant to be backported to 3.0.

@jsvob jsvob requested review from ryan-blakley and bfahr December 12, 2022 22:53
@ryan-blakley
Copy link
Contributor

So I don't want to modify/diverge the 3.0 branch's setup.py file from master, because it would require two commits each time a change is needed to the file and it might get overwritten by accident when cherry picking. Additionally the 3.0 branch is the release branch it's not intended to develop with, and it isn't designed to run on only 3.6. The develop branch is generally meant to run on the latest version available in RHEL which is 3.9 right now.

The PR you referenced was submitted to address broken doc build tests on PRs that broke due to a newer ipython version. Is this just affecting your local setup or a test in another project. I can play around with making changes to require a different version on 3.6, but it would require going back and pinning other module versions as well for 3.6.

@ryan-blakley
Copy link
Contributor

@jsvob Could you test if changing the line to ipython!=8.7.0 works for you in 3.6? That should allow the docs build test to work off master and for it to work on the 3.0 branch on 3.6.

@ryan-blakley
Copy link
Contributor

Actually we discuss this in our PR meeting, and setting to ipython<8.7.0 should be better until we can confirm the fix is fixed in a future ipython version. Also please make this change to both branches not just the 3.0 branch.

@jsvob jsvob changed the base branch from 3.0 to master December 14, 2022 08:50
@bfahr
Copy link
Contributor

bfahr commented Dec 14, 2022

@jsvob I think you just need to resubmit the change as a new PR. The change you've made is correct but at least some of the errors are due to the fact that the commits on the 3.0 branch have been cherry-picked from master and don't match-up.

@jsvob
Copy link
Member Author

jsvob commented Dec 14, 2022

Thanks. That's strange. I created a new local branch with the same name but based on master and force-pushed it to my remote, and changed this PR to merge to master. It seems github or CI just caches something, even though from the perspective of git-as-a-graph it makes no sense for github to fail like that.
New PR: #3630

@jsvob
Copy link
Member Author

jsvob commented Dec 14, 2022

Closed in favor of #3630

@jsvob jsvob closed this Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants