fix: add deprecated warning message in insights.combiners.mounts #3613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psachin
reviewed
Nov 28, 2022
insights/combiners/mounts.py
Outdated
| @@ -42,6 +43,7 @@ class Mounts(object): | |||
| """ | |||
|
|
|||
| def __init__(self, binmount, procmounts, mountinfo): | |||
| deprecated(Mounts, "Use the parsers in insights.mount module instead", "3.1.0") | |||
There was a problem hiding this comment.
@chenlizhong Please make it 3.1.25 which means we can remove it after the release of 3.2.0 which is roughly six months from now.
xiangce
requested changes
Nov 29, 2022
xiangce
approved these changes
Nov 30, 2022
xiangce
pushed a commit
that referenced
this pull request
Dec 1, 2022
* fix: add deprecated warning message in insights.combiners.mounts Signed-off-by: Chen lizhong <[email protected]> * fix: update version to 3.1.25 Signed-off-by: Chen lizhong <[email protected]> * docs: add deprecated info into doc string Signed-off-by: Chen lizhong <[email protected]> * docs: use warning instead of note Signed-off-by: Chen lizhong <[email protected]> (cherry picked from commit c79bf52)
xiangce
pushed a commit
that referenced
this pull request
Sep 6, 2024
* fix: add deprecated warning message in insights.combiners.mounts Signed-off-by: Chen lizhong <[email protected]> * fix: update version to 3.1.25 Signed-off-by: Chen lizhong <[email protected]> * docs: add deprecated info into doc string Signed-off-by: Chen lizhong <[email protected]> * docs: use warning instead of note Signed-off-by: Chen lizhong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chen lizhong [email protected]
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
Before remove the combiner.mounts, give deprecate warning by this MR.
#3606