Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add datasource to get jboss versions #3600

Merged
merged 0 commits into from
Nov 29, 2022
Merged

Add datasource to get jboss versions #3600

merged 0 commits into from
Nov 29, 2022

Conversation

chenlizhong
Copy link
Contributor

@chenlizhong chenlizhong commented Nov 17, 2022 •
edited by xiangce
Loading

Signed-off-by: Chen lizhong [email protected]

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

Add your description here

@chenlizhong chenlizhong requested a review from xiangce November 17, 2022 08:33
ryan-blakley
ryan-blakley requested changes Nov 17, 2022
View reviewed changes
insights/specs/default.py Outdated Show resolved Hide resolved
insights/specs/__init__.py Outdated Show resolved Hide resolved
insights/specs/datasources/ps.py Show resolved Hide resolved
insights/specs/datasources/ps.py Show resolved Hide resolved
xiangce
xiangce reviewed Nov 18, 2022
View reviewed changes
Copy link
Contributor

@xiangce xiangce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And for new spec (or datasource), it should get the approval in the core-assets repo before adding to the core collection.

insights/specs/datasources/ps.py Outdated Show resolved Hide resolved
insights/specs/datasources/ps.py Outdated Show resolved Hide resolved
insights/specs/datasources/ps.py Outdated Show resolved Hide resolved
@chenlizhong chenlizhong requested a review from psachin November 25, 2022 06:27
@xiangce xiangce merged commit 278aa87 into master Nov 29, 2022
@xiangce xiangce deleted the get_jboss_version branch November 29, 2022 06:59
bfahr pushed a commit that referenced this pull request Nov 29, 2022
@chenlizhong @bfahr
Add datasource to get jboss versions (#3600)
b13a25b 
* Add datasource to get jboss versions

Signed-off-by: Chen lizhong <[email protected]>

* Update order
* Refact codes

Signed-off-by: Chen lizhong <[email protected]>
(cherry picked from commit 278aa87)
@chenlizhong chenlizhong mentioned this pull request Dec 21, 2022
Merged
3 tasks
xiangce pushed a commit that referenced this pull request Sep 6, 2024
@chenlizhong
Add datasource to get jboss versions (#3600)
dda5fd2 
* Add datasource to get jboss versions

Signed-off-by: Chen lizhong <[email protected]>

* Update order
* Refact codes

Signed-off-by: Chen lizhong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psachin psachin psachin approved these changes

@ryan-blakley ryan-blakley ryan-blakley approved these changes

@xiangce xiangce xiangce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chenlizhong @psachin @ryan-blakley @xiangce