Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Specs] ls_var_lib_pcp #3590

Merged
merged 0 commits into from
Nov 17, 2022
Merged

[New Specs] ls_var_lib_pcp #3590

merged 0 commits into from
Nov 17, 2022

Conversation

mohitkumarrh
Copy link
Contributor

@mohitkumarrh mohitkumarrh commented Nov 11, 2022

Signed-off-by: Mohit Kumar [email protected]

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

Add your description here

insights/specs/__init__.py Outdated Show resolved Hide resolved
insights/specs/default.py Outdated Show resolved Hide resolved
insights/specs/insights_archive.py Outdated Show resolved Hide resolved
insights/tests/parsers/test_ls_var_lib_pcp.py Outdated Show resolved Hide resolved
insights/parsers/ls_var_lib_pcp.py Outdated Show resolved Hide resolved
@mohitkumarrh
Copy link
Contributor Author

@xiangce - Thanks for the review, I'll make all the changes.

@mohitkumarrh
Copy link
Contributor Author

py.test:

➜  insights-core git:(new_specs_ls_var_lib_pcp) ✗ py.test -svk ls_var_lib_pcp --cov=insights.parsers.ls_var_lib_pcp
=========================================================================== test session starts ===========================================================================
platform darwin -- Python 3.9.1, pytest-7.1.2, pluggy-1.0.0 -- /Users/mohitkumar/.pyenv/versions/3.9.1/bin/python3.9
cachedir: .pytest_cache
rootdir: /Users/mohitkumar/Insights/insights-core, configfile: setup.cfg, testpaths: insights
plugins: cov-3.0.0
collecting 603 items                                                                                                                                                      
Downloading a fresh and hot uploader.json...
collected 2942 items / 2940 deselected / 2 selected                                                                                                                       

insights/tests/parsers/test_ls_var_lib_pcp.py::test_ls_var_lib_pcp PASSED
insights/tests/parsers/test_ls_var_lib_pcp.py::test_ls_var_lib_pcp_doc_examples PASSED

---------- coverage: platform darwin, python 3.9.1-final-0 -----------
Name                                 Stmts   Miss Branch BrPart  Cover   Missing
--------------------------------------------------------------------------------
insights/parsers/ls_var_lib_pcp.py       6      0      2      0   100%
--------------------------------------------------------------------------------
TOTAL                                    6      0      2      0   100%


=================================================================== 2 passed, 2940 deselected in 6.57s ====================================================================

@mohitkumarrh
Copy link
Contributor Author

@xiangce @psachin - I have updated the PR as you suggested, please review again

@psachin
Copy link
Contributor

psachin commented Nov 17, 2022

@mohitkumarrh This looks good to me now.

@psachin
Copy link
Contributor

psachin commented Nov 17, 2022

/ Pending specs approval /

@psachin psachin merged commit 63a7fb8 into RedHatInsights:master Nov 17, 2022
psachin pushed a commit that referenced this pull request Nov 17, 2022
Signed-off-by: Mohit Kumar <[email protected]>

Signed-off-by: Mohit Kumar <[email protected]>
(cherry picked from commit 63a7fb8)
vdymna pushed a commit that referenced this pull request Nov 22, 2022
Signed-off-by: Mohit Kumar <[email protected]>

Signed-off-by: Mohit Kumar <[email protected]>
xiangce pushed a commit that referenced this pull request Sep 6, 2024
Signed-off-by: Mohit Kumar <[email protected]>

Signed-off-by: Mohit Kumar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants