Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update system_user_dirs datasource #3586

Merged
merged 3 commits into from
Nov 10, 2022
Merged

Update system_user_dirs datasource #3586

merged 3 commits into from
Nov 10, 2022

Conversation

jobselko
Copy link
Contributor

@jobselko jobselko commented Nov 7, 2022

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

This PR should fix the complexity issue and also update the code logic, which was not entirely accurate.

Signed-off-by: Jitka Obselkova <[email protected]>
Signed-off-by: Jitka Obselkova <[email protected]>
@jobselko jobselko requested review from xiangce and bfahr November 7, 2022 16:44
Signed-off-by: Jitka Obselkova <[email protected]>
Copy link
Contributor

@xiangce xiangce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jobselko

@xiangce xiangce merged commit 9a6b5c3 into RedHatInsights:master Nov 10, 2022
xiangce pushed a commit that referenced this pull request Nov 10, 2022
* Optimize the code

Signed-off-by: Jitka Obselkova <[email protected]>

* Update code logic

Signed-off-by: Jitka Obselkova <[email protected]>

* Update code as recommended

Signed-off-by: Jitka Obselkova <[email protected]>
(cherry picked from commit 9a6b5c3)
xiangce pushed a commit that referenced this pull request Sep 6, 2024
* Optimize the code

Signed-off-by: Jitka Obselkova <[email protected]>

* Update code logic

Signed-off-by: Jitka Obselkova <[email protected]>

* Update code as recommended

Signed-off-by: Jitka Obselkova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants