fix: LuksDump not parsing multiple data segments #3569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @danzatt, would you mind adding such a case to the test of this parser? |
Signed-off-by: daniel.zatovic <[email protected]>
Signed-off-by: daniel.zatovic <[email protected]>
danzatt
force-pushed
the
fix-luksdump-parser
branch
from
d22485a to
77e2d69
Compare
|
Sorry, I missed that one. Done now. |
xiangce
approved these changes
Nov 1, 2022
psachin
approved these changes
Nov 3, 2022
psachin
pushed a commit
that referenced
this pull request
Nov 3, 2022
* fix: LuksDump not parsing multiple data segments Signed-off-by: daniel.zatovic <[email protected]> * Add regression test for parsing luksDump segments Signed-off-by: daniel.zatovic <[email protected]> Signed-off-by: daniel.zatovic <[email protected]> (cherry picked from commit 568dbf9)
xiangce
pushed a commit
that referenced
this pull request
Sep 6, 2024
* fix: LuksDump not parsing multiple data segments Signed-off-by: daniel.zatovic <[email protected]> * Add regression test for parsing luksDump segments Signed-off-by: daniel.zatovic <[email protected]> Signed-off-by: daniel.zatovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: daniel.zatovic [email protected]
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
Every second-level section in the
cryptsetup luksDumpoutput is immediately followed (without a newline) by another second-level section. E.g. the "Digests" sectionHowever, when there are multiple data segments, there is a newline:
Most of the time, there is a single data segment. However, during re-encryption, there might appear multiple segments. The parser didn't assume this.