Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove duplicated specs from get_dependency_specs #3549

Merged
merged 0 commits into from
Oct 13, 2022

Conversation

xiangce
Copy link
Contributor

@xiangce xiangce commented Oct 13, 2022

Signed-off-by: Xiangce Liu [email protected]

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

This Patch removed the duplicated items from the list returned by get_dependency_specs

@xiangce xiangce requested a review from psachin October 13, 2022 02:34
@xiangce xiangce marked this pull request as ready for review October 13, 2022 02:34
@xiangce xiangce force-pushed the en_get_specs branch 2 times, most recently from fb5b18b to 9a923c2 Compare October 13, 2022 06:48
@xiangce xiangce merged commit 730b663 into master Oct 13, 2022
@xiangce xiangce deleted the en_get_specs branch October 13, 2022 06:55
xiangce added a commit that referenced this pull request Oct 13, 2022
* refactor: remove duplicated specs from the result of get_dependency_specs

Signed-off-by: Xiangce Liu <[email protected]>

* update the conditions name in the test

Signed-off-by: Xiangce Liu <[email protected]>
(cherry picked from commit 730b663)
xiangce added a commit that referenced this pull request Sep 6, 2024
* refactor: remove duplicated specs from the result of get_dependency_specs

Signed-off-by: Xiangce Liu <[email protected]>

* update the conditions name in the test

Signed-off-by: Xiangce Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants