-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add helper function: get_dependency_specs and test #3534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangce
force-pushed
the
get_dependency_specs
branch
from
September 27, 2022 09:43
e6b9644
to
a6c53c0
Compare
Test Coverage:
This function locates in L364 ~ L424. Its coverage reaches 100%. |
xiangce
changed the title
feat: add help function: get_dependency_specs and test
feat: add helper function: get_dependency_specs and test
Sep 27, 2022
xiangce
force-pushed
the
get_dependency_specs
branch
from
September 27, 2022 10:04
8b3c856
to
547650b
Compare
xiangce
requested review from
vdymna,
bfahr,
lhuett,
psachin and
ryan-blakley
September 28, 2022 02:42
Signed-off-by: Xiangce Liu <[email protected]>
Signed-off-by: Xiangce Liu <[email protected]>
Signed-off-by: Xiangce Liu <[email protected]>
Signed-off-by: Xiangce Liu <[email protected]>
Signed-off-by: Xiangce Liu <[email protected]>
Signed-off-by: Xiangce Liu <[email protected]>
Signed-off-by: Xiangce Liu <[email protected]>
Signed-off-by: Xiangce Liu <[email protected]>
Signed-off-by: Xiangce Liu <[email protected]>
Signed-off-by: Xiangce Liu <[email protected]>
xiangce
force-pushed
the
get_dependency_specs
branch
from
September 29, 2022 08:59
9d6076b
to
36eb9e1
Compare
psachin
approved these changes
Oct 6, 2022
psachin
pushed a commit
that referenced
this pull request
Oct 6, 2022
* feat: add helper function: "get_dependency_specs" and test Signed-off-by: Xiangce Liu <[email protected]> * coverage 100% Signed-off-by: Xiangce Liu <[email protected]> * fix typo in test Signed-off-by: Xiangce Liu <[email protected]> * fix doc error Signed-off-by: Xiangce Liu <[email protected]> * doc: move the note back to the example Signed-off-by: Xiangce Liu <[email protected]> * fix test for python 2 Signed-off-by: Xiangce Liu <[email protected]> * add more docs Signed-off-by: Xiangce Liu <[email protected]> * remove blank line Signed-off-by: Xiangce Liu <[email protected]> * make the get_requires() looks more reasonable and add test Signed-off-by: Xiangce Liu <[email protected]> * Refine the code a bit Signed-off-by: Xiangce Liu <[email protected]> Signed-off-by: Xiangce Liu <[email protected]> (cherry picked from commit 430c852)
xiangce
added a commit
that referenced
this pull request
Sep 6, 2024
* feat: add helper function: "get_dependency_specs" and test Signed-off-by: Xiangce Liu <[email protected]> * coverage 100% Signed-off-by: Xiangce Liu <[email protected]> * fix typo in test Signed-off-by: Xiangce Liu <[email protected]> * fix doc error Signed-off-by: Xiangce Liu <[email protected]> * doc: move the note back to the example Signed-off-by: Xiangce Liu <[email protected]> * fix test for python 2 Signed-off-by: Xiangce Liu <[email protected]> * add more docs Signed-off-by: Xiangce Liu <[email protected]> * remove blank line Signed-off-by: Xiangce Liu <[email protected]> * make the get_requires() looks more reasonable and add test Signed-off-by: Xiangce Liu <[email protected]> * Refine the code a bit Signed-off-by: Xiangce Liu <[email protected]> Signed-off-by: Xiangce Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
Add a helper function to the
insights.core.dr
module to get the dependency specs from a loaded component.