feat: Add combiner rhel for edge #3526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wushiqinlou
changed the title
wushiqinlou
changed the title
Signed-off-by: jiazhang <[email protected]>
Signed-off-by: jiazhang <[email protected]>
xiangce
reviewed
Sep 19, 2022
Signed-off-by: jiazhang <[email protected]>
Signed-off-by: jiazhang <[email protected]>
lhuett
reviewed
Sep 20, 2022
Signed-off-by: jiazhang <[email protected]>
Signed-off-by: jiazhang <[email protected]>
Signed-off-by: jiazhang <[email protected]>
Signed-off-by: jiazhang <[email protected]>
xiangce
approved these changes
Sep 21, 2022
jobselko
reviewed
Sep 21, 2022
There was a problem hiding this comment.
Hi @wushiqinlou, I have a few comments, but probably nothing important. You can ignore them and resolve these discussions if you think they are unnecessary.
In the end, I am not the one who approves this PR :)
Signed-off-by: jiazhang <[email protected]>
Signed-off-by: jiazhang <[email protected]>
skontar
approved these changes
Sep 22, 2022
3 tasks
psachin
pushed a commit
that referenced
this pull request
Sep 22, 2022
* Add combiner rhel_for_edge Signed-off-by: jiazhang <[email protected]> * Update test Signed-off-by: jiazhang <[email protected]> * Update return format Signed-off-by: jiazhang <[email protected]> * Remove SkipComponent Signed-off-by: jiazhang <[email protected]> * Update description Signed-off-by: jiazhang <[email protected]> * Update description format Signed-off-by: jiazhang <[email protected]> * Update description format Signed-off-by: jiazhang <[email protected]> * Add note Signed-off-by: jiazhang <[email protected]> * Update long condition Signed-off-by: jiazhang <[email protected]> * Update condition format Signed-off-by: jiazhang <[email protected]> Signed-off-by: jiazhang <[email protected]> (cherry picked from commit db2b6bc)
xiangce
pushed a commit
that referenced
this pull request
Sep 6, 2024
* Add combiner rhel_for_edge Signed-off-by: jiazhang <[email protected]> * Update test Signed-off-by: jiazhang <[email protected]> * Update return format Signed-off-by: jiazhang <[email protected]> * Remove SkipComponent Signed-off-by: jiazhang <[email protected]> * Update description Signed-off-by: jiazhang <[email protected]> * Update description format Signed-off-by: jiazhang <[email protected]> * Update description format Signed-off-by: jiazhang <[email protected]> * Add note Signed-off-by: jiazhang <[email protected]> * Update long condition Signed-off-by: jiazhang <[email protected]> * Update condition format Signed-off-by: jiazhang <[email protected]> Signed-off-by: jiazhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
Create a combiner to determine if it is an edge computing system.