fix: the parser "LvmConfig" raises exception #3476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* It fails to parse the content when there is "umask=077" in the global configuration. Signed-off-by: Huanhuan Li <[email protected]>
|
@xiangce Please help to review, thanks. |
Signed-off-by: Huanhuan Li <[email protected]>
xiangce
reviewed
Jul 26, 2022
Signed-off-by: Huanhuan Li <[email protected]>
xiangce
reviewed
Jul 28, 2022
Signed-off-by: Huanhuan Li <[email protected]>
Signed-off-by: Huanhuan Li <[email protected]>
xiangce
approved these changes
Jul 28, 2022
psachin
approved these changes
Jul 28, 2022
xiangce
pushed a commit
that referenced
this pull request
Jul 28, 2022
* fix: the parser "LvmConfig" raises exception * It fails to parse the content when there is "umask=077" in the global configuration. Signed-off-by: Huanhuan Li <[email protected]> * Only fix "umask=077" and keep the other strings as integer Signed-off-by: Huanhuan Li <[email protected]> * Transfer the value first before storing Signed-off-by: Huanhuan Li <[email protected]> * Keep data as dict Signed-off-by: Huanhuan Li <[email protected]> * Add test for ParseException Signed-off-by: Huanhuan Li <[email protected]> (cherry picked from commit 9e7ccce)
xiangce
pushed a commit
that referenced
this pull request
Sep 6, 2024
* fix: the parser "LvmConfig" raises exception * It fails to parse the content when there is "umask=077" in the global configuration. Signed-off-by: Huanhuan Li <[email protected]> * Only fix "umask=077" and keep the other strings as integer Signed-off-by: Huanhuan Li <[email protected]> * Transfer the value first before storing Signed-off-by: Huanhuan Li <[email protected]> * Keep data as dict Signed-off-by: Huanhuan Li <[email protected]> * Add test for ParseException Signed-off-by: Huanhuan Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fails to parse the content when there is "umask=077" in the configuration.
Signed-off-by: Huanhuan Li [email protected]
All Pull Requests:
Check all that apply:
fixes: A bug of parser "LvmConfig" #3475