Feat: Add teamdctl_state_dump spec to insights_archive #3455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangce
reviewed
Jun 30, 2022
psachin
approved these changes
Jul 6, 2022
xiangce
reviewed
Jul 11, 2022
added 6 commits
July 12, 2022 10:58
Signed-off-by: Xinting Li <[email protected]>
Signed-off-by: Xinting Li <[email protected]>
Signed-off-by: Xinting Li <[email protected]>
Signed-off-by: Xinting Li <[email protected]>
Signed-off-by: Xinting Li <[email protected]>
Signed-off-by: Xinting Li <[email protected]>
xiangce
reviewed
Jul 13, 2022
| if content: | ||
| team_device_list = [] | ||
| for x in content: | ||
| if 'team' in x['TYPE']: |
There was a problem hiding this comment.
Would you please double confirm if the disconnected team interfaces good candidates to this parser?
| list: List of the team device. | ||
|
|
||
| Raises: | ||
| SkipComponent: When there is not any content. |
There was a problem hiding this comment.
This would be When there is not any team interfaces.
|
|
||
|
|
||
| @datasource(NmcliConnShow, HostContext) | ||
| def team_device(broker): |
There was a problem hiding this comment.
Better rename it as team_interfaces?
added 2 commits
July 13, 2022 11:12
Signed-off-by: Xinting Li <[email protected]>
Signed-off-by: Xinting Li <[email protected]>
psachin
approved these changes
Jul 14, 2022
xiangce
pushed a commit
that referenced
this pull request
Jul 14, 2022
* Feat: Add teamdctl_state_dump spec to insights_archive Signed-off-by: Xinting Li <[email protected]> * fix:erroneously modify ethtool_k Signed-off-by: Xinting Li <[email protected]> * Modify path Signed-off-by: Xinting Li <[email protected]> * Add team test Signed-off-by: Xinting Li <[email protected]> * move team_device to ethernet Signed-off-by: Xinting Li <[email protected]> * Update test for team_device Signed-off-by: Xinting Li <[email protected]> * Filtered discounted teams Signed-off-by: Xinting Li <[email protected]> * correct abbreviation Signed-off-by: Xinting Li <[email protected]> Co-authored-by: Xinting Li <[email protected]> (cherry picked from commit dea3e1f)
xiangce
pushed a commit
that referenced
this pull request
Sep 6, 2024
* Feat: Add teamdctl_state_dump spec to insights_archive Signed-off-by: Xinting Li <[email protected]> * fix:erroneously modify ethtool_k Signed-off-by: Xinting Li <[email protected]> * Modify path Signed-off-by: Xinting Li <[email protected]> * Add team test Signed-off-by: Xinting Li <[email protected]> * move team_device to ethernet Signed-off-by: Xinting Li <[email protected]> * Update test for team_device Signed-off-by: Xinting Li <[email protected]> * Filtered discounted teams Signed-off-by: Xinting Li <[email protected]> * correct abbreviation Signed-off-by: Xinting Li <[email protected]> Co-authored-by: Xinting Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xinting Li [email protected]
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
teamdctl_state_dump spec only exists in sos-archive.py currently, but some insights-plugin rules also use the related parser.
Add teamdctl_state_dump spec to default.py.