fix: Move _LogRotateConf parser out of combiner #3389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Due to an issue found with the httpdconf parser that was in the combiner I'm moving the newer logrotate parser out of it's combiner as well. * Added docstring to the moved parser, and added doctest. Signed-off-by: Ryan Blakley <[email protected]>
xiangce
approved these changes
Apr 19, 2022
|
This once looks good to me and, I think it can be merged directly since it won't break any tests of existing rules. |
bfahr
approved these changes
Apr 19, 2022
lhuett
pushed a commit
that referenced
this pull request
Apr 19, 2022
* Due to an issue found with the httpdconf parser that was in the combiner I'm moving the newer logrotate parser out of it's combiner as well. * Added docstring to the moved parser, and added doctest. Signed-off-by: Ryan Blakley <[email protected]> (cherry picked from commit 408be4f)
xiangce
pushed a commit
that referenced
this pull request
Sep 6, 2024
* Due to an issue found with the httpdconf parser that was in the combiner I'm moving the newer logrotate parser out of it's combiner as well. * Added docstring to the moved parser, and added doctest. Signed-off-by: Ryan Blakley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply:
Complete Description of Additions/Changes:
Due to an issue found with the httpdconf parser that was in the combiner I'm moving the newer logrotate parser out of it's combiner as well. Added docstring to the moved parser, and added doctest.