fix: Switch to reading crontab file rather than run the command #3359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Based on the comments in bz 1759080, I switched the crontab specs to read the crontab files instead of running the command since it does user id look ups every time the command is ran. But by switching to simple_file the spec would be skipped if the file doesn't exist. Signed-off-by: Ryan Blakley <[email protected]>
bfahr
requested changes
Mar 15, 2022
bfahr
approved these changes
Mar 21, 2022
xiangce
pushed a commit
that referenced
this pull request
Mar 23, 2022
* Based on the comments in bz 1759080, I switched the crontab specs to read the crontab files instead of running the command since it does user id look ups every time the command is ran. But by switching to simple_file the spec would be skipped if the file doesn't exist. Signed-off-by: Ryan Blakley <[email protected]> (cherry picked from commit 3535655)
xiangce
pushed a commit
that referenced
this pull request
Sep 6, 2024
* Based on the comments in bz 1759080, I switched the crontab specs to read the crontab files instead of running the command since it does user id look ups every time the command is ran. But by switching to simple_file the spec would be skipped if the file doesn't exist. Signed-off-by: Ryan Blakley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply:
Complete Description of Additions/Changes:
Based on the complaints in bz 1759080, I switched the crontab specs to read the crontab files instead of running the command since it does user id look ups every time the command is ran. But by switching to simple_file the spec would be skipped if the file doesn't exist. I also added the nova_conf file as a dep for the nova_uid so that the id look up doesn't occur unless nova is installed.