feat: Add systctl.d spec, parser, and combiner #3358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangce
reviewed
Mar 14, 2022
xiangce
reviewed
Mar 16, 2022
xiangce
reviewed
Mar 16, 2022
xiangce
reviewed
Mar 16, 2022
* Currently core only collects /etc/sysctl.conf but none of the conf files in the /usr/lib/sysctl.d/ and /etc/sysctl.d/ directories. So I added a spec for them and added a spec for the /usr/lib/sysctl.d/ directory as well. * Updated the parsers to use a base class to avoid duplicate code. * Added a new combiner for all of the conf files in the /usr/lib/sysctl.d/ and /etc/sysctl.d/ directories along with the /etc/sysctl.conf file. Signed-off-by: Ryan Blakley <[email protected]>
xiangce
approved these changes
Mar 17, 2022
psachin
pushed a commit
that referenced
this pull request
Mar 17, 2022
* Currently core only collects /etc/sysctl.conf but none of the conf files in the /usr/lib/sysctl.d/ and /etc/sysctl.d/ directories. So I added a spec for them and added a spec for the /usr/lib/sysctl.d/ directory as well. * Updated the parsers to use a base class to avoid duplicate code. * Added a new combiner for all of the conf files in the /usr/lib/sysctl.d/ and /etc/sysctl.d/ directories along with the /etc/sysctl.conf file. Signed-off-by: Ryan Blakley <[email protected]> (cherry picked from commit 66979b8)
xiangce
pushed a commit
that referenced
this pull request
Sep 6, 2024
* Currently core only collects /etc/sysctl.conf but none of the conf files in the /usr/lib/sysctl.d/ and /etc/sysctl.d/ directories. So I added a spec for them and added a spec for the /usr/lib/sysctl.d/ directory as well. * Updated the parsers to use a base class to avoid duplicate code. * Added a new combiner for all of the conf files in the /usr/lib/sysctl.d/ and /etc/sysctl.d/ directories along with the /etc/sysctl.conf file. Signed-off-by: Ryan Blakley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check all that apply:
Complete Description of Additions/Changes:
Currently core only collects /etc/sysctl.conf but none of the conf files in the /etc/sysctl.d/ directory. So I added a spec for them. Updated the parsers to use a base class. Added a new combiner for all of the conf files in the /etc/sysctl.d/ directory.