Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't log the insights-core egg in verbose mode #3348

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

mhuth
Copy link
Contributor

@mhuth mhuth commented Mar 2, 2022

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?

Complete Description of Additions/Changes:

https://bugzilla.redhat.com/show_bug.cgi?id=2045995

From the BZ: "If there is a new Egg available to download the whole binary content of the new Egg (zip) file is dumped to the terminal. This binary content has also terminal control characters and PuTTy and responds also to them". This only happens when verbose mode is enabled, and only under certain conditions (eg after deleting the etag file).

@mhuth mhuth force-pushed the dont_log_insights_core_egg branch from 01a8ea2 to 75c46dc Compare March 2, 2022 08:34
@mhuth mhuth force-pushed the dont_log_insights_core_egg branch from 75c46dc to 7ecb85c Compare March 2, 2022 08:39
@mhuth mhuth requested a review from subpop March 2, 2022 13:20
@subpop subpop merged commit 0e8c8d8 into master Mar 2, 2022
subpop pushed a commit that referenced this pull request Mar 2, 2022
@xiangce xiangce deleted the dont_log_insights_core_egg branch May 5, 2023 07:44
xiangce pushed a commit that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants