feat: New parser for systemd_perms #3339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 17, 2022 00:31
Signed-off-by: Xinting Li <[email protected]>
Signed-off-by: Xinting Li <[email protected]>
|
@xiangce Please have a review. |
xiangce
requested changes
Feb 21, 2022
There was a problem hiding this comment.
@TZ3070 - These two parsers are in fact Ls like parsers, would you please rename them (includes the filename) with a prefix Ls like others, e.g.
insights-core/insights/parsers/ls_sys_firmware.py
Lines 45 to 46 in cc2e262
Signed-off-by: Xinting Li <[email protected]>
xiangce
requested changes
Feb 21, 2022
There was a problem hiding this comment.
@TZ3070 - Please check my new comments below
And 1) since this is a new parser file, please add doc entry for it in the docs/shared_parsers_catalog/ dir, so that its online document can be generated automatically. 2), for newly added specs parsers, please raise an MR to the insights-core-assets repo at first to make sure they can be added to the uploader.json.
insights/parsers/ls_systemd.py
Outdated
|
|
||
| Parsers included in this module are: | ||
|
|
||
| SystemdPerms - command ``/bin/ls -lanRL /etc/systemd`` |
There was a problem hiding this comment.
This should be modified too.
insights/parsers/ls_systemd.py
Outdated
| SystemdPerms - command ``/bin/ls -lanRL /etc/systemd`` | ||
| -------------------------------------------------------------- | ||
|
|
||
| UsrLibSystemdPerms - command ``/bin/ls -lanRL /usr/lib/systemd`` |
insights/parsers/ls_systemd.py
Outdated
|
|
||
|
|
||
| @parser(Specs.ls_etc_systemd) | ||
| class LsEtcSystemdPermsParser(CommandParser, FileListing): |
There was a problem hiding this comment.
How above removing the part of PermsParser?
xiangce
reviewed
Feb 21, 2022
xiangce
reviewed
Feb 21, 2022
added 3 commits
February 22, 2022 11:30
Signed-off-by: Xinting Li <[email protected]>
Signed-off-by: Xinting Li <[email protected]>
Signed-off-by: Xinting Li <[email protected]>
xiangce
approved these changes
Feb 23, 2022
Signed-off-by: Xinting Li <[email protected]>
xiangce
approved these changes
Feb 23, 2022
Signed-off-by: Xinting Li <[email protected]>
xiangce
pushed a commit
that referenced
this pull request
Mar 4, 2022
* feat: New parser for systemd_perms Signed-off-by: Xinting Li <[email protected]> * fix: fix ETC_SYSTEMD in test_systemd_perms.py Signed-off-by: Xinting Li <[email protected]> * fix: Fix file name and class name Signed-off-by: Xinting Li <[email protected]> * fix: add doc entry Signed-off-by: Xinting Li <[email protected]> * fix: update insights_archive Signed-off-by: Xinting Li <[email protected]> * fix: fix docs-test error Signed-off-by: Xinting Li <[email protected]> * fix: fix length of '-' Signed-off-by: Xinting Li <[email protected]> * fix: Updating test_etc_systemd() in test_ls_systemd.py Signed-off-by: Xinting Li <[email protected]> Co-authored-by: Xinting Li <[email protected]> (cherry picked from commit 92d671e)
xiangce
pushed a commit
that referenced
this pull request
Sep 6, 2024
* feat: New parser for systemd_perms Signed-off-by: Xinting Li <[email protected]> * fix: fix ETC_SYSTEMD in test_systemd_perms.py Signed-off-by: Xinting Li <[email protected]> * fix: Fix file name and class name Signed-off-by: Xinting Li <[email protected]> * fix: add doc entry Signed-off-by: Xinting Li <[email protected]> * fix: update insights_archive Signed-off-by: Xinting Li <[email protected]> * fix: fix docs-test error Signed-off-by: Xinting Li <[email protected]> * fix: fix length of '-' Signed-off-by: Xinting Li <[email protected]> * fix: Updating test_etc_systemd() in test_ls_systemd.py Signed-off-by: Xinting Li <[email protected]> Co-authored-by: Xinting Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xinting Li [email protected]
All Pull Requests:
Check all that apply:
Complete Description of Additions/Changes:
Add your description here