Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update file paths for foreman related specs as per sosreport changes #2385

Closed
Rohan21Lobo opened this issue Dec 24, 2019 · 2 comments
Closed

Update file paths for foreman related specs as per sosreport changes #2385

Rohan21Lobo opened this issue Dec 24, 2019 · 2 comments

Comments

@Rohan21Lobo
Copy link
Contributor

Rohan21Lobo commented Dec 24, 2019 •
edited
Loading

Since sos-3.7, foreman and related plugins data is collected in native plugins instead of collecing foreman-debug
sosreport/sos#1525

Paths for specs need to be updated
@Rohan21Lobo
Copy link
Contributor Author

Rohan21Lobo commented Dec 24, 2019 •
edited
Loading

puppet_ssl_cert_ca_pem

  • Added new path for puppet_ssl_cert_ca_pem spec

Qpid Specs

For qpid-stat -q
In new sos changes, qpid commands were moved to sos's katello plugin. In satellite 6.6, qpid-client cert path got changed from /etc/pki/katello/qpid_client_striped.crt to /etc/pki/pulp/qpid/client.crt . This gives 2 combinations :

  • sos_commands/katello/qpid-stat_-u_--ssl-certificate_.etc.pki.pulp.qpid.client.crt_-b_amqps_..localhost_5671
  • sos_commands/katello/qpid-stat_-u_--ssl-certificate_.etc.pki.katello.qpid_client_striped.crt_-b_amqps_..localhost_5671

In sos's code, qpid commands got moved to pulp plugin recently. This change is yet to be rebased in downstream sos.
sosreport/sos#1805

This gives another 2 combinations :

  • sos_commands/pulp/qpid-stat_-q_--ssl-certificate_.etc.pki.pulp.qpid.client.crt_-b_amqps_..localhost_5671
  • sos_commands/pulp/qpid-stat_-q_--ssl-certificate_.etc.pki.katello.qpid_client_striped.crt_-b_amqps_..localhost_5671

Same as above for qpid-stat -u spec

Keeping old foreman-debug related paths also. The files are in order of newest to oldest changes.

Rohan21Lobo pushed a commit to Rohan21Lobo/insights-core that referenced this issue Dec 24, 2019
Update foreman sos_archive spec paths (RedHatInsights#2385)
00852cb 
Since sos-3.7, foreman related data is collected via native sos plugins
instead of collecting foreman-debug. So spec file paths for sos_archive
needs to be updated.

Signed-off-by: Rohan Arora <[email protected]>
@xiangce xiangce mentioned this issue Dec 25, 2019
Merged
xiangce pushed a commit that referenced this issue Dec 25, 2019
@xiangce
Update foreman sos_archive spec paths (#2385) (#2386)
31b4e45 
Since sos-3.7, foreman related data is collected via native sos plugins
instead of collecting foreman-debug. So spec file paths for sos_archive
needs to be updated.

Signed-off-by: Rohan Arora <[email protected]>
@xiangce
Copy link
Contributor

xiangce commented Dec 25, 2019

#2386 resolved it

@xiangce xiangce closed this as completed Dec 25, 2019
xiangce pushed a commit that referenced this issue Dec 25, 2019
@xiangce
Update foreman sos_archive spec paths (#2385) (#2386)
0c6abd8 
Since sos-3.7, foreman related data is collected via native sos plugins
instead of collecting foreman-debug. So spec file paths for sos_archive
needs to be updated.

Signed-off-by: Rohan Arora <[email protected]>
(cherry picked from commit 31b4e45)
gravitypriest pushed a commit that referenced this issue Jan 6, 2020
Update foreman sos_archive spec paths (#2385) (#2386)
022fa9c 
Since sos-3.7, foreman related data is collected via native sos plugins
instead of collecting foreman-debug. So spec file paths for sos_archive
needs to be updated.

Signed-off-by: Rohan Arora <[email protected]>
Signed-off-by: Jeremy Crafts <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xiangce @Rohan21Lobo